[Bug 17282] New: Ability to create charts for SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Bug ID: 17282 Summary: Ability to create charts for SQL reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 55412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55412&action=edit Bug 17282 - Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - make reports, - draw charts, - that's all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55412|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55442&action=edit [SIGNED-OFF]Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - make reports, - draw charts, - that's all Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Could be better if we can only use the dropdown menu to download the chart. I propose this patch, if you think that is bad idea, please make it obsolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55444&action=edit Bug 17282: (follow-up) Use drop-down menu for download chart instead To Test 1) Execute a report 2) Click in drop-down menu "Download" shows only three options 3) Draw a chart 4) Click again in drop-down menu "Download" shows a new option "Download chart" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55444|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 55480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55480&action=edit Bug 17282: (follow-up) Use drop-down menu for download chart instead To Test 1) Execute a report 2) Click in drop-down menu "Download" shows only three options 3) Draw a chart 4) Click again in drop-down menu "Download" shows a new option "Download chart" Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments: 1/ Would it be possible to add a "loading please wait" when processing the graph? 2/ Execute a report which raises an error, you will get a JS error: 3/ If I delete a column, the scrollbar goes to the top 4/ I can delete all the columns and click on "draw", nothing happens. It should not bz possible to delete the first column I'd say. 5/ With the following query: SELECT i.homebranch, h.branchcode, monthname(h.reservedate) AS month, year(h.reservedate) AS year, count(*) FROM old_reserves h LEFT JOIN items i USING (itemnumber) WHERE h.branchcode != i.homebranch AND year(h.reservedate) = '2015' GROUP BY month(h.reservedate), h.branchcode With chart type: "Pie", x column: "month" and y: "count(*)", I get the following JS error: TypeError: columns[index] is undefined Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #7 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #6)
2/ Execute a report which raises an error, you will get a JS error:
Have you an exemple of report that raise error ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #7)
(In reply to Jonathan Druart from comment #6)
2/ Execute a report which raises an error, you will get a JS error:
Have you an exemple of report that raise error ?
SELECT itemtype, count(*) FROM items group by itemtype; should do the trick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 55582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55582&action=edit Bug 17282 - Fix QA comments: - Don't scroll to the top when deleting a column, - prevents to delete all columns, - better handling of headers/results deleting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55582|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 55586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55586&action=edit Bug 17282 - Fix QA comments: - Don't scroll to the top when deleting a column, - prevents to delete all columns, - better handling of headers/results deleting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 55588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55588&action=edit Bug 17282 - Ability to exclude the last line in report results This patch add a checkbox (exclude last line). This is useful when this last is the result of a sql rollup which is the sum of each column and make the chart not consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55442|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55604&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - make reports, - draw charts, - that's all Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55480|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55605&action=edit Bug 17282: (follow-up) Use drop-down menu for download chart instead To Test 1) Execute a report 2) Click in drop-down menu "Download" shows only three options 3) Draw a chart 4) Click again in drop-down menu "Download" shows a new option "Download chart" Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55586|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55606&action=edit Bug 17282 - Fix QA comments: - Don't scroll to the top when deleting a column, - prevents to delete all columns, - better handling of headers/results deleting Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55588|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55607&action=edit Bug 17282 - Ability to exclude the last line in report results This patch add a checkbox (exclude last line). This is useful when this last is the result of a sql rollup which is the sum of each column and make the chart not consistent Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #16 from Alex Arnaud <alex.arnaud@biblibre.com> --- Currently, graphs are built using the data of the page (Because this the only available variable in the template). For reports with paging, this means that all data are not took in account. I'm wondering if we should not make that possible. How ? Get all data with an AJAX call during making the graph ? It seems to be a big work to AJAXify this part of the code. Feedback are welcome -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #16)
Currently, graphs are built using the data of the page (Because this the only available variable in the template). For reports with paging, this means that all data are not took in account. I'm wondering if we should not make that possible. How ? Get all data with an AJAX call during making the graph ? It seems to be a big work to AJAXify this part of the code.
Feedback are welcome
It seems reasonable, for a first version, to built the graph with the data displayed on the page. But it would be nice to tell the user how it works with a small info box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
It seems reasonable, for a first version, to built the graph with the data displayed on the page. But it would be nice to tell the user how it works with a small info box.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6) Some of the comments from comment 6 have not been fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55868&action=edit Bug 17282: Use fieldset.rows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55869&action=edit Bug 17282: Remove use of onclick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #22 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 62529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62529&action=edit Bug 17282 - Fix QA comments - Add a loading message, - prevent JS error when report fails, - fix (bootstrap 3 ?) displaying problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #23 from Marc Véron <veron@veron.ch> --- Looking forward to this feature! Wanted to test but first patch does not apply on newest master (lot of commits today). automatischer Merge von koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt KONFLIKT (Inhalt): Merge-Konflikt in koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt automatischer Merge von koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc KONFLIKT (hinzufügen/hinzufügen): Merge-Konflikt in koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55604|0 |1 is obsolete| | --- Comment #24 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 63565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63565&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - make reports, - draw charts, - that's all Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55605|0 |1 is obsolete| | --- Comment #25 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 63566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63566&action=edit Bug 17282: (follow-up) Use drop-down menu for download chart instead To Test 1) Execute a report 2) Click in drop-down menu "Download" shows only three options 3) Draw a chart 4) Click again in drop-down menu "Download" shows a new option "Download chart" Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55606|0 |1 is obsolete| | --- Comment #26 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 63567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63567&action=edit Bug 17282 - Fix QA comments: - Don't scroll to the top when deleting a column, - prevents to delete all columns, - better handling of headers/results deleting Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55607|0 |1 is obsolete| | --- Comment #27 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 63568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63568&action=edit Bug 17282 - Ability to exclude the last line in report results This patch add a checkbox (exclude last line). This is useful when this last is the result of a sql rollup which is the sum of each column and make the chart not consistent Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55868|0 |1 is obsolete| | --- Comment #28 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 63569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63569&action=edit Bug 17282: Use fieldset.rows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55869|0 |1 is obsolete| | --- Comment #29 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 63570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63570&action=edit Bug 17282: Remove use of onclick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #30 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 63571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63571&action=edit Bug 17282 - Fix QA comments - Add a loading message, - prevent JS error when report fails, - fix (bootstrap 3 ?) displaying problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Could you please rebase? I am getting fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt). on the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63565|0 |1 is obsolete| | --- Comment #32 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67225&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - make reports, - draw charts, - that's all Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63566|0 |1 is obsolete| | --- Comment #33 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67226&action=edit Bug 17282: (follow-up) Use drop-down menu for download chart instead To Test 1) Execute a report 2) Click in drop-down menu "Download" shows only three options 3) Draw a chart 4) Click again in drop-down menu "Download" shows a new option "Download chart" Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63567|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67227&action=edit Bug 17282 - Fix QA comments: - Don't scroll to the top when deleting a column, - prevents to delete all columns, - better handling of headers/results deleting Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63568|0 |1 is obsolete| | --- Comment #35 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67228&action=edit Bug 17282 - Ability to exclude the last line in report results This patch add a checkbox (exclude last line). This is useful when this last is the result of a sql rollup which is the sum of each column and make the chart not consistent Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63569|0 |1 is obsolete| | --- Comment #36 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67229&action=edit Bug 17282: Use fieldset.rows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63570|0 |1 is obsolete| | --- Comment #37 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67230&action=edit Bug 17282: Remove use of onclick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63571|0 |1 is obsolete| | --- Comment #38 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 67231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67231&action=edit Bug 17282 - Fix QA comments - Add a loading message, - prevent JS error when report fails, - fix (bootstrap 3 ?) displaying problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, very cool feature! Some small things to fix: - Add information about the new Javascript libraries to the about page with the license etc. - QA tools - just make it "" instead. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 966) - Maybe it would be nicer to display the settings on top, activated by a new button in the toolbar. What do you think? At the moment the problem I see that a lot of libraries like to print that page for a quick overview and the new settings will print on an extra page at the bottom. Also if the table is long, you have to scroll down quite a bit. Deadlines are close now, I will try to come back to this fast. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #40 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69174&action=edit Bug 17282 - Add information about the new Javascript libraries in the about page - fix a QA warning - Move chart settings on top and make them hidden by default - Add options to get all results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67231|0 |1 is obsolete| | Attachment #69174|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69429&action=edit Bug 17282 - Fix QA comments - Add a loading message, - prevent JS error when report fails, - fix (bootstrap 3 ?) displaying problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69430&action=edit Bug 17282 - Add information about the new Javascript libraries in the about page - fix a QA warning - Move chart settings on top and make them hidden by default - Add options to get all results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last 2 patches fix conflict on staff-global.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69430|0 |1 is obsolete| | --- Comment #44 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 69493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69493&action=edit Bug 17282 - Add information about the new Javascript libraries in the about page - fix a QA warning - Move chart settings on top and make them hidden by default - Add options to get all results Patch applies and functions as expected when following test plan. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 13219 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Jens Weber <jens.weber@phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jens.weber@phsh.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67225|0 |1 is obsolete| | Attachment #67226|0 |1 is obsolete| | Attachment #67227|0 |1 is obsolete| | Attachment #67228|0 |1 is obsolete| | Attachment #67229|0 |1 is obsolete| | Attachment #67230|0 |1 is obsolete| | Attachment #69429|0 |1 is obsolete| | Attachment #69493|0 |1 is obsolete| | --- Comment #47 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79182&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - execute a report, - click on show chart settings button (in the tool bar), - draw chart (click on draw button), - check the chart Features: - Include all rows (ignore pagination), - Download the chart (svg), - Choose x column and y columns, - Exclude last line (Rollup) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79182|0 |1 is obsolete| | --- Comment #48 from Michal Denar <black23@gmail.com> --- Created attachment 79230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79230&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - execute a report, - click on show chart settings button (in the tool bar), - draw chart (click on draw button), - check the chart Features: - Include all rows (ignore pagination), - Download the chart (svg), - Choose x column and y columns, - Exclude last line (Rollup) Signed-off-by: Michal Denare <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #49 from Michal Denar <black23@gmail.com> --- Nice feature, I really love it. Thank You ... Mike -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- I started to testing 21393 with this one, so my QA tools are on steroids now ;) Few comments 1) Missing filters: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc FAIL filters missing_filter at line 26 ( <option value="[% header.cell %]">[% header.cell %]</option>) missing_filter at line 46 ( <a class="chart-column-delete" href="#" data-column="[% column %]">) missing_filter at line 72 ( <option value="[% i %]">[% i %]</option>) missing_filter at line 47 ( <img src="[% interface %]/[% theme %]/img/x.png" alt="Delete" />) missing_filter at line 24 ( <option value="[% supposed_x %]" selected>[% supposed_x %]</option>) missing_filter at line 70 ( <option value="[% i %]" selected>[% i %]</option>) missing_filter at line 56 ( <option value="[% h.cell %]" selected>[% h.cell %]</option>) missing_filter at line 52 ( <select id="y_[% column %]" name="y">) missing_filter at line 58 ( <option value="[% h.cell %]">[% h.cell %]</option>) missing_filter at line 43 ( <fieldset class="chart-column-conf" id="column_[% column %]" style="display: inline !important;">) missing_filter at line 66 ( <label for="group_[% column %]">Group:</label>) missing_filter at line 81 ( <input class="column-line" id="column-line" name="[% header.cell %]" type="checkbox">) missing_filter at line 67 ( <select id="group_[% column %]" name="group">) missing_filter at line 45 ( Column [% column %]) missing_filter at line 94 ( [% header_row.unshift(item) %]) missing_filter at line 51 ( <label for="y_[% column %]" >y:</label>) missing_filter at line 80 ( <label for="line_[% column %]">line:</label>) missing_filter at line 53 ( <option value="[% supposed_x %]" selected>[% supposed_x %]</option>) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt FAIL filters missing_filter at line 1108 ( $('#chart').prepend('<div style="font-size: 1rem; text-align: center;">' + "[% name %]" + '</div>');) missing_filter at line 1058 ( results = [% results.json %]) missing_filter at line 1055 ( results = [% allresults.json %]) missing_filter at line 1051 ( headers = [% header_row.json %];) 2) Could you please split the patch? At least staff-global.css should not be in main patch, as it is generated by RM and here should be only for ease the testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79230|0 |1 is obsolete| | --- Comment #51 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79308&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - execute a report, - click on show chart settings button (in the tool bar), - draw chart (click on draw button), - check the chart Features: - Include all rows (ignore pagination), - Download the chart (svg), - Choose x column and y columns, - Exclude last line (Rollup) Signed-off-by: Michal Denare <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #52 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79309&action=edit Bug 17282: [DO NOT PUSH] provide staff-global.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #53 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79310&action=edit Bug 17282: add template's variable filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79308|0 |1 is obsolete| | --- Comment #54 from Michal Denar <black23@gmail.com> --- Created attachment 79311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79311&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - execute a report, - click on show chart settings button (in the tool bar), - draw chart (click on draw button), - check the chart Features: - Include all rows (ignore pagination), - Download the chart (svg), - Choose x column and y columns, - Exclude last line (Rollup) Signed-off-by: Michal Denare <black23@gmail.com> Signed-off-by: Michal Denar <black23ěgmail.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79309|0 |1 is obsolete| | --- Comment #55 from Michal Denar <black23@gmail.com> --- Created attachment 79312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79312&action=edit Bug 17282: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23ěgmail.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79310|0 |1 is obsolete| | --- Comment #56 from Michal Denar <black23@gmail.com> --- Created attachment 79313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79313&action=edit Bug 17282: add template's variable filters Signed-off-by: Michal Denar <black23ěgmail.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #57 from Michal Denar <black23@gmail.com> --- Sorry I've no idea what default name and email was added :-( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Michal, how did you sign off? I notice there is this line in your patches today: Signed-off-by: Your Full Name <your_email>, but also a correct sign-off line: Signed-off-by: Michal Denar <black23ěgmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Shouldn't that ě also be an @ sign in the signoff too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79311|0 |1 is obsolete| | Attachment #79312|0 |1 is obsolete| | Attachment #79313|0 |1 is obsolete| | --- Comment #60 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79337&action=edit Bug 17282: Ability to create charts for SQL reports Add a form under report's result that allow to configure and draw a chart (pie, bar, line and combination). Pie: Usefull only for a two-column report's result bar: Horizontal: Can be horizontal or vertical (check/uncheck horizontal checkbox), Group: allows to group columns (stacked bar chart), Line: show some columns as line in a bar chart (combination) line: line chart :) This patch adds 2 new js libraries: d3js and c3js: - c3.min.css - c3.min.js - d3.min.js Test plan: - Apply this patch, - execute a report, - click on show chart settings button (in the tool bar), - draw chart (click on draw button), - check the chart Features: - Include all rows (ignore pagination), - Download the chart (svg), - Choose x column and y columns, - Exclude last line (Rollup) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #61 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79338&action=edit Bug 17282: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #62 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79339&action=edit Bug 17282: add template's variable filters Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- This is very cool. I think some of the lines in chart.inc need filters? They are not failing the test but want to make sure before pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #63)
I think some of the lines in chart.inc need filters? They are not failing the test but want to make sure before pushing.
Which ones? Did you see the last patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #65 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #64)
(In reply to Nick Clemens from comment #63)
I think some of the lines in chart.inc need filters? They are not failing the test but want to make sure before pushing.
Which ones? Did you see the last patch?
/me is embarassed, my bad -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great enhancement, won't be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Be great to have some release notes text for this.. highlight it a bit during 18.11 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Add a form under report's release notes| |result that allow to | |configure and draw a | |chart | |(pie, bar, line and | |combination). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Add a form under report's |Adds a form under report's release notes|result that allow to |result that allows to |configure and draw a |configure and draw a |chart |chart |(pie, bar, line and |(pie, bar, line and |combination). |combination). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22168 [Bug 22168] Improve styling of new chart settings for reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org