[Bug 6369] New: Formatting problems on some items when printing an order form (PDF).
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Bug #: 6369 Summary: Formatting problems on some items when printing an order form (PDF). Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org Created attachment 4174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4174 Correct a formatting problem in the pdf generation of basketgroup.pl In /acqui/basketgroup.pl : When printing an order form for a basketgroup, some items appeared incorrectly in the resulting pdf file. The formatting problem happens if $ord->{itemtype} has a value, but $bib->{itemtype} does not. Patch attached to correct this problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|henridamien@koha-fr.org |fcapovilla@live.ca -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> 2011-05-18 20:47:44 UTC --- More details : The formatting problem happens when a biblioitem has an itemtype that doesn't exist in the itemtypes table. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-10 03:28:20 UTC --- Frederic (without a k :)) Did you miss sending or attaching the signed off patch? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4174|0 |1 is obsolete| | --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-11 08:56:22 UTC --- Created attachment 4960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4960 proposed patch (passed QA) QA comment * seems Frédéric D. signed-off patch has been lost in limbo * tested the patch, works as expected & fixes the problem Marking "passed QA" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-12 01:46:50 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-02 22:00:17 UTC --- At the moment pdf printing seems to be broken for me, so I can't close this bug yet. The pdf files I create have following text inside: <h1>Software error:</h1> <pre>Undefined subroutine &main::printpdf called at /home/katrin/kohaclone/acqui/basketgroup.pl line 275. </pre> Investigating... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7138 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 --- Comment #6 from Frédérick Capovilla <fcapovilla@live.ca> 2011-11-04 14:04:49 UTC --- (In reply to comment #5)
At the moment pdf printing seems to be broken for me, so I can't close this bug yet. The pdf files I create have following text inside:
<h1>Software error:</h1> <pre>Undefined subroutine &main::printpdf called at /home/katrin/kohaclone/acqui/basketgroup.pl line 275. </pre>
Investigating...
The problem appeared in 3.6. See Bug 7138 . -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-09 14:54:22 UTC --- The line 275 shows : my $pdf = printpdf($basketgroup, $bookseller, $baskets, \%orders, $bookseller->{gstrate} // C4::Context->preference("gist")) || die "pdf generation failed"; printpdf is supposed to be loaded at line 190 : my $pdfformat = C4::Context->preference("OrderPdfFormat"); if ($pdfformat eq 'pdfformat::layout3pages' || $pdfformat eq 'pdfformat::layout2pages'){ eval { require $pdfformat; import $pdfformat; }; So, what does OrderPdfFormat contains ? If it's not pdfformat::layout3pages or pdfformat::layout2pages, nothing is "require-ed", and printpdf fails -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-09 15:28:47 UTC --- Paul, plz also check 7138. I have tested entering nothing or a wrong value in the system preference. The browser shows a nice error message in this case now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-09 16:19:43 UTC --- yikes. The "depends on" link is really not visible enough, I missed it (once again), thx kf. patch 7138 pushed, this one can be tested now I think -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-30 06:56:13 UTC --- I set biblioitems.itype to an invalid value. PDF still printing correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6369 Bug 6369 depends on bug 7138, which changed state. Bug 7138 Summary: Can't print basket group order pdf. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7138 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org