[Bug 5474] New: Missing sys prefs in translated sysprefs.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 Summary: Missing sys prefs in translated sysprefs.sql Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Installation and upgrade (web-based installer) AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 The translated sysprefs.sql files are missing some newer changes, because people only add changes and new parameters to en, but not to the other languages. Example: homeorholdingbranchreturn is missing from de-DE Tagsmoderation is still NULL instead of 0 I looked at it-IT and other files too, the total of lines varies. I think all files need to be checked and have probably differences to en. There is a test in directory xt/syspref.t ok 1 - Open reference syspref file installer/data/mysql/en/mandatory/sysprefs.sql ok 2 - Found 250 sysprefs ok 3 - Open translated sysprefs file installer/data/mysql/de-DE/mandatory/sysprefs.sql ok 4 - Found 248 sysprefs not ok 5 - No syspref to add ok 6 - No syspref to delete ok 7 - Open translated sysprefs file installer/data/mysql/it-IT/necessari/sysprefs.sql ok 8 - Found 257 sysprefs not ok 9 - No syspref to add not ok 10 - No syspref to delete ok 11 - Open translated sysprefs file installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql ok 12 - Found 250 sysprefs not ok 13 - No syspref to add not ok 14 - No syspref to delete ok 15 - Open translated sysprefs file installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql ok 16 - Found 200 sysprefs not ok 17 - No syspref to add not ok 18 - No syspref to delete ok 19 - Open translated sysprefs file installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql ok 20 - Found 200 sysprefs not ok 21 - No syspref to add [...] It shows the missing system preferences, but does not catch the changed default value for TagsModeration. Fixing all syspref.files is one option - but with the new translatable syspref editor another option would perhaps be to always use the en files. A script to create the sql from the .pref files would probably be even better. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2010-12-07 05:36:26 UTC --- This has been discussed on koha-devel mailing list. For example: http://listes.koha-fr.org/pipermail/koha-devel/2010-July/034214.html The syspref SQL file is required during installation to populate systemepreferences table with default value. It isn't needed for anything else being replaced by .pref files which are translatable. Table syspreferences description, type and other fields are deprecated. When a new syspref is added -- It must be added in: - installer/data/mysql/en/mandatory/syspref.sql to define default value. - installer/data/mysql/updatedatabase.sql to update an existing installation. A DB upgrade must be done: SOMEONE should describe the exact procedure. - koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/ in the appropriate subdirectory and .pref file. When a syspref is updated: - .pref file must be modified - If a default value is required: installer/data/mysql/en/mandatory/syspref.sql - If necessary, a DB update and a message to explain what has to be done by Koha admin concerning the new syspref. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@gmail.com --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-12-10 09:47:37 UTC --- HomeOrHoldingBranchReturn is also missing from *.pref. This preference can't be edited. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Depends on| |5531 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches@biblibre.com --- Comment #3 from dev_patches@biblibre.com 2010-12-21 23:29:23 UTC --- branch pushed wip/sysprefs_translated on wip/koha-biblibre.git It removes some sysprefs used in the code though. So maybe would need some more reconciliation with .pref and sysprefs.sql work. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #4 from Magnus Enger <magnus@enger.priv.no> 2011-06-01 14:01:26 UTC --- *** Bug 6441 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 --- Comment #5 from Magnus Enger <magnus@enger.priv.no> 2011-06-01 14:04:53 UTC --- I started an RFC for less error-prone handling of sysprefs on the wiki: http://wiki.koha-community.org/wiki/Simplified_syspref_handling_RFC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 Bug 5474 depends on bug 5531, which changed state. Bug 5531 Summary: Missing sysprefs in language specific files http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5531 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5474 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |paul.poulain@biblibre.com Resolution| |DUPLICATE --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-05 09:04:01 UTC --- partial duplicate of 5531 + we changed how sysprefs work, so the problem won't happen anymore *** This bug has been marked as a duplicate of bug 5531 *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org