[Bug 24169] New: Advanced editor: icons/buttons for sorting the search results are missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Bug ID: 24169 Summary: Advanced editor: icons/buttons for sorting the search results are missing Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: carnold@dgiinc.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl After 19.11 the sorting icons for the search results disappeared. The search still works if you click on the header of the column, but the icons are gone. 19.05: https://paste.pics/8694b71e22504d77439b877166ca5e77 19.11: https://paste.pics/301f28373f9fc57756e401855fcb063b -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Depends on| |23013 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by bug 23013. cateditor-ui.inc is using .sorting_asc and .sorting_desc that were define in datatables.css Now the CSS definitions are more precise (table.dataTable thead .sorting_asc) and are no longer applied to the th. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96385&action=edit Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96385|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96386&action=edit Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Cori Lynn Arnold <carnold@dgiinc.com> --- Works great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, does not it sound more correct to copy the CSS definitions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
Owen, does not it sound more correct to copy the CSS definitions?
It would be more correct, but I think the satisfaction of being technically correct would be outweighed by the effort. I think a pragmatic fix is better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96386|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96469&action=edit Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96470&action=edit Bug 24169: Add a comment to clarify the use of the dataTable class Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #6)
(In reply to Jonathan Druart from comment #5)
Owen, does not it sound more correct to copy the CSS definitions?
It would be more correct, but I think the satisfaction of being technically correct would be outweighed by the effort. I think a pragmatic fix is better.
It seemed easy to copy the 5 lines, and I was going to propose an alternative patch. But then I realised that we may also want the other .dataTable definitions as well. I guess that why you thought the effort was consequent, I did not think about that at first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Bug 24169 depends on bug 23013, which changed state. Bug 23013 Summary: Upgrade DataTables in the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org