[Bug 6373] New: The mandatory fields validation popup doesn't appear in IE8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Bug #: 6373 Summary: The mandatory fields validation popup doesn't appear in IE8 Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Created attachment 4190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4190 Corrects a validation problem on addbiblio.pl on IE8 On /cataloguing/addbiblio.pl : In some cases, the mandatory field validation popup doesn't appear when trying to add a new bibliographic record on IE8. It seems this line makes IE8 stop executing the AreMandatoriesNotOk function : document.getElementById(mandatories[i]).focus(); I replaced this line with its JQuery equivalent and it seems to fix the problem: $('#' + mandatories[i]).focus(); Patch attached -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|gmcharlt@gmail.com |fcapovilla@live.ca -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4190|0 |1 is obsolete| | --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-05-19 16:09:48 UTC --- Created attachment 4192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4192 Signed-off patch Signed-off patch includes one minor edit: I removed the commented-out line which the jQuery line replaces. We have git to track changes for us, we don't have to leave old code in. This patch fixes the problem, which I was able to reproduce in IE8 on Win7. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Browser compatibility Version|rel_3_2 |master Patch Status|Needs Signoff |Signed Off AssignedTo|fcapovilla@live.ca |oleonard@myacpl.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 --- Comment #2 from Frédérick Capovilla <fcapovilla@live.ca> 2011-05-19 16:14:41 UTC --- Just a detail : The commented line doesn't seem to have been removed in the signed-off patch... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-05-19 16:16:52 UTC ---
The commented line doesn't seem to have been removed in the signed-off patch...
Indeed. My git-fu must be failing me today. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4192|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-11 09:34:45 UTC --- Created attachment 4961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4961 proposed patch (passed QA) QA comment As for previous patch for IE8 * Koha not guaranteed to work on IE * I don't have any IE at hand * I've reintroduced the comment owen forgot to upload * I've checked the patch is harmless under FF * Frédérick & Owen says it worked for them Marking passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6373 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-12 01:46:44 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org