[Bug 19663] New: Move JS to the footer: Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Bug ID: 19663 Summary: Move JS to the footer: Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, nick@bywatersolutions.com, simon.pouchol@biblibre.com, testopia@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header. This patch will do so for reports templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69249&action=edit Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69249|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69264&action=edit Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Owen, just a small thing: the function Dopop in cat_issues_top.tt template should be probably removed, it is not used if I am reading it right. Otherwise looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69264|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69603&action=edit Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Fix for QA: Remove unused Dopop function. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69603|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69771&action=edit Bug 19663: Move JS to the footer: Reports This patch modifies the staff client's reports templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of reports pages: All button controls, DataTables functionality, form validation, etc. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Fix for QA: Remove unused Dopop function. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backporting for 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34533 [Bug 34533] jsdiff library missing from guided reports page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org