https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|RT46421 - SelfCheck Display |SelfCheck Display CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 Component|Architecture, internals, |Self checkout |and plumbing | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 86331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86331&action=edit Bug 21772: Move OPAC holds and account tables into .inc This patch moves the code to render the account and holds information for the patron into include files. They are loaded in the opac-user.tt and opac-account.tt templates respectively. To test: 1) Have a patron with account lines and holds 2) Notice they are displayed in the patron's detail section in the OPAC 3) Apply this patch 4) Reload the patron's detail page => SUCESS: Everything looks the same, no behaviuor or layout change. 5) Sign off Sponsored-by: City of Portsmouth Public Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 86333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86333&action=edit Bug 21772: Add holds and account information to SCO This patch introduces holds and account information to the SCO page. It uses the introduced include files that are also used in OPAC (opac-user.pl and opac-account.pl). To test: 1) Have a patron that has holds and account lines 2) Enable the SCO module 3) Use the patron's cardnumber to get to its details => SUCCESS: New tabs are presented, and they display holds and account information as expected 4) Sign off :-D Sponsored-by: City of Portsmouth Public Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add holds information tab |Add holds and account |to the SCO module |information tab to the SCO | |module -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com --- Comment #6 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- Agustín, I tested the patch and the functionality works. Is it possible to include more information in the tab labels in SCO, as it is displayed in opac-user.pl? Such as: Checkouts (0) Holds (1) Fines and charges (16.99) Thanks, Sarah -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #8 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- The tabs look good. I'm almost ready to sign off. At some point in my testing the SCO shut down. I think it was because the SCO was trying to edit an item as part of the normal process. I reproduced the shutdown when I tried to edit an item in the intranet. This is one of the last lines of the plack log when it shuts down: Use of uninitialized value $searchid in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 853. 2019/03/12-19:48:38 Server closing! I don't see why it would be related but I'm new to testing on the sandboxes so I have to ask! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- I got the same behavior (tab closes when invoking additem.pl) when testing another bug in the sandboxes, even after clearing cookies and only using the intranet. So I guess it is unrelated to this bug. I'm signing off because your patches work. If this isn't the right thing to do, I'm sure someone will let me know! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 [Bug 22538] Add a noticeable alert about waiting holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86332|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 86332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86332 Bug 21772: (follow-up) QA failed because old bootstrap button class This is false positive. In opac, we still use class btn-mini as Bootstrap in opac was not upgraded to version 3 and is still using version 2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86331|0 |1 is obsolete| | Attachment #86333|0 |1 is obsolete| | Attachment #86334|0 |1 is obsolete| | Attachment #86495|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87042&action=edit Bug 21772: Move OPAC holds and account tables into .inc This patch moves the code to render the account and holds information for the patron into include files. They are loaded in the opac-user.tt and opac-account.tt templates respectively. To test: 1) Have a patron with account lines and holds 2) Notice they are displayed in the patron's detail section in the OPAC 3) Apply this patch 4) Reload the patron's detail page => SUCESS: Everything looks the same, no behaviuor or layout change. 5) Sign off Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell@cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87044&action=edit Bug 21772: (follow-up) Remove redundant variable Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell@cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87046&action=edit Bug 21772: (QA follow-up) Hide .tdlabel class in sco for consistancy with opac-user page. Test plan: 1) Compare holds table on selfcheckout and opac-user page, you will see the difference: In self checkout there are labels like Status, Pickup location, and so on in every table cell. 2) Apply the patch, the label in selfcheckout dissappear Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87048&action=edit Bug 21772: (QA follow-up) Fix setting variables to PROCESS in holds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87064&action=edit Bug 21772: (follow-up) Minor markup correction and reindentation This patch makes one minor markup correction: In HTML5 <tfoot> must be after <tbody>. Previously the opposite was true. I've also done a little bit of opinionated reindentation. There should be no changes visible to the user from this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87064|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 87067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87067&action=edit Bug 21772: (follow-up) Minor markup correction and reindentation This patch makes one minor markup correction: In HTML5 <tfoot> must be after <tbody>. Previously the opposite was true. I've also done a little bit of opinionated reindentation. There should be no changes visible to the user from this patch. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #23 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Owen Leonard from comment #20)

I hope you don't mind the minor follow-up. I can submit on a separate bug if that's better.

Looks great, thanks :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold -- You are receiving this mail because: You are watching all bug changes.