[Bug 9835] New: Brackets missing for branches for patron attribute types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Bug ID: 9835 Summary: Brackets missing for branches for patron attribute types Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: brendan@bywatersolutions.com CC: gmcharlt@gmail.com Software error: Can't call method "branches" on an undefined value at kohaclone/admin/patron-attr-types.pl line 300. For help, please send mail to the webmaster (webmaster@mybox), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 16245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16245&action=edit proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |christophe.croullebois@bibl | |ibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Its a typo all right but fetch can also return undef shouldn't we also check for that?? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Does this cause a problem which can be reproduced? Can the outcome be tested? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16245|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16585&action=edit bug 9835: Lack of brackets in patron-attr-types.pl line 300 produces a warning 'Can't call method "branches" on an undefined value'... Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | Severity|enhancement |normal --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have seen the error on Brendan's installation, but can't reproduce right now - maybe someone else can? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- I cannot reproduced. And I don't understand the patch. C4::Members::AttributeTypes has a branches method and it is the method we want to call. I would prefer: $attr->{branches} = $attr_type->branches if defined $attr_type; But at this place, $attr_type should be defined. Could you produce a test plan to reproduce the issue please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- I can only repeat this on my install and we have not been able to repeat this anywhere else - we have tried four other installs and I have tried other installs on other boxes. I think we can just disregard this bug until another person reports this problem. -Brendan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9835 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org