[Bug 15788] New: Split borrowers permission into create/edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Bug ID: 15788 Summary: Split borrowers permission into create/edit Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/patron-edit- permission/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Goal : Add ability to control if a staff user can create new patrons vs editing existing patrons Work to be done: 1) Add new borrowers sub-permission ‘modify’ 2) Add new borrowers sub-permission ‘create’ 3) Implement new permissions for patron editor/creator Looking for sponsors here: http://devs.bywatersolutions.com/projects/patron-edit-permission/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- I think ideally we would add a third 'delete' permission, updated site link: http://devs.bywatersolutions.com/2016/11/30/Split-borrowers-permission-into-... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Split borrowers permission |Split borrowers permission |into create/edit |into create/edit and delete -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 8535 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard@myacpl.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com --- Comment #3 from Jessie Zairo <jzairo@bywatersolutions.com> --- I think in addition to giving a delete permission, we should also had a merge patron permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com --- Comment #4 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- We just had our first accidental borrower deletion in almost 2 years, so I'm pleased to see this is already suggested! I'd like to see permissions broken down thus: create modify renew delete merge The funding link is broken. Is there still a call out for cosponsors? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree about delete and merge - but I am unsure about splitting create and modify. Say you create a new patron, but you discover you have typoed the email address or phone number after saving - you won't be able to fix it, if you don't have create and modify. I feel like they both should go together, but wonder if there is a use case where splitting makes sense? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #6 from Fiona Borthwick <fiona.borthwick@ptfs-europe.com> --- One of our large public library customers is due to go live next month and are currently working out their staff permissions. This exact question has been asked - can they give the DELETE permission to some members of staff but not to others? This would be a very welcome enhancement as we really don't offer many patron permissions at all at present. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115091&action=edit Bug 15788: Add delete_borrowers permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115092&action=edit Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- These patches simply add a 'delete_borrowers' sub-permissions and bind the option to delete borrowers to it. All other 'edit_borrowers' options should remain intact. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Anyone fancy testing this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #11 from David Nind <david@davidnind.com> --- After applying the patch and the database update: - You can't expand any of the "Show details" to see the sub permissions for a patron. - There is an error in the web developer tools console: Uncaught ReferenceError: CAN_user_borrowers_delete_borrowers is not defined <anonymous> Ember jQuery 4 i fireWith ready J (A link is also provided to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Not... ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115091|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118865&action=edit Bug 15788: Add delete_borrowers permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115092|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118866&action=edit Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for testing David.. I found the issue, I'd neglected to add one of the files to the final commit! All sorted now, should be working this time around.. Doh! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118865|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 118874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118874&action=edit Bug 15788: Add delete_borrowers permission Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118866|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 118875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118875&action=edit Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows release notes| |administrators to control, | |at a more fine-grained | |level, which users may | |delete patron records. | | | |This patch introduces a new | |`delete_borrowers` user | |permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121887&action=edit Bug 15788: Add delete_borrowers permission Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121888&action=edit Bug 15788: Use delete_borrowers permission Link the new delete_borrowers sub-permission to the delete actions. Test plan 1/ Remove the delete_borrowers permission from a staff user 2/ Check that the user cannot use the 'Delete' option from the members menu. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121889&action=edit Bug 15788: (QA follow-up) Simplify query in update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 121890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121890&action=edit Bug 15788: Make the API require the new permission Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like we are missing renew and merge. It would have been good to split this bug report. Pushing as it anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org