[Bug 31834] New: Inconsistent table formatting for list of MARC imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Bug ID: 31834 Summary: Inconsistent table formatting for list of MARC imports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Blocks: 31833 The table has a line on top of the header line, which is inconsistent with other pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833 [Bug 31833] [Omnibus] Fix table inconsistencies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31902 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142515&action=edit Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the <table> tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a <thead> and <tbody>, with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Looks better, and all the HTML is valid. My apologies as I think I was the one to add that 'table' class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142515|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142550&action=edit Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the <table> tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a <thead> and <tbody>, with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142550|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142554&action=edit Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the <table> tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a <thead> and <tbody>, with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834 Bug 31834 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org