[Bug 11417] New: remove_unused_authorities.pl doesn't accept --test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Bug ID: 11417 Summary: remove_unused_authorities.pl doesn't accept --test Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: gaetan.boisson@biblibre.com QA Contact: testopia@bugs.koha-community.org remove_unused_authorities.pl says in the help that it will accept both --test and --t as arguments in order to only test and count eligible authorities without removing them : This script will parse all authoritiestypes given as parameter, and remove authorities without any biblio attached. warning : there is no individual confirmation ! parameters --aut|authtypecode TYPE the list of authtypes to check --t|test test mode, don't delete really, just count --help or -h show this message. but in practice it only accepts --t : GetOptions( 'aut|authtypecode:s' => \@authtypes, 't' => \$test, 'h|help' => \$want_help ); A user launching the script with --test will see a warning that there was an unrecognised option, and the authorities will be deleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |gaetan.boisson@biblibre.com --- Comment #1 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Created attachment 23632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23632&action=edit Bug 11417 - remove_unused_authorities.pl doesn't accept --test See commit message for the test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23632|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 23661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23661&action=edit Bug 11417: make sure remove_unused_authorities.pl accepts --test This patches adds support for the --test option, as well as a short message telling the user the script is running in test mode. Test plan : - Launch the script with -h to see the help - Launch the script with --test and --aut with an authtypecode that is used in your instance - Make sure it does the same thing as launching it with -t - Launch the script for real and make sure it still works as expected, deleting unused authorities. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23661|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23667&action=edit Bug 11417: make sure remove_unused_authorities.pl accepts --test This patches adds support for the --test option, as well as a short message telling the user the script is running in test mode. Test plan : - Launch the script with -h to see the help - Launch the script with --test and --aut with an authtypecode that is used in your instance - Make sure it does the same thing as launching it with -t - Launch the script for real and make sure it still works as expected, deleting unused authorities. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Gaetan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.3. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.11. Thanks Gaetan! This is an important fix! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org