[Bug 26394] New: .mailmap needs to be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Bug ID: 26394 Summary: .mailmap needs to be updated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The .mailmap file used to generate the stats is different from the one we have in our repo. It's much more complete and should be integrated into Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109679&action=edit Bug 26394: Update .mailmap The .mailmap file used to generate the stats is different from the one we have in our repo. It's much more complete and should be integrated into Koha. Test plan: Confirm that the different mappings are correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109679|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109843&action=edit Bug 26394: Update .mailmap The .mailmap file used to generate the stats is different from the one we have in our repo. It's much more complete and should be integrated into Koha. Test plan: Confirm that the different mappings are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- These look good to me.. I compared them to the dev_map.yaml we have in the release tools and on visual inspection that all seemed to agree with each other. At some point, I should write a script to merge to two and then dump the custom format yaml from the release tools so we can rely on just the mailmap file and encourage its ongoing maintenance by the rm/rmaints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109843|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109882&action=edit Bug 26394: Update .mailmap The .mailmap file used to generate the stats is different from the one we have in our repo. It's much more complete and should be integrated into Koha. Test plan: Confirm that the different mappings are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Keywords|RM_priority | Version(s)| |20.11.00 released in| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 [Bug 26621] .mailmap adjustments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The .mailmap file is used release notes| |to map author and committer | |names and email addresses | |to canonical real names and | |email addresses. It has | |been improved to reflect | |the current project's | |history. | |It helps to have a | |cleaner authors list and | |prevent duplicate | |http://git.koha-community.o | |rg/stats/koha-master/author | |s.html Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The .mailmap file is used |The .mailmap file is used release notes|to map author and committer |to map author and committer |names and email addresses |names and email addresses |to canonical real names and |to canonical real names and |email addresses. It has |email addresses. It has |been improved to reflect |been improved to reflect |the current project's |the current project's |history. |history. |It helps to have a |It helps to have a |cleaner authors list and |cleaner authors list and |prevent duplicate |prevents duplicate |http://git.koha-community.o |http://git.koha-community.o |rg/stats/koha-master/author |rg/stats/koha-master/author |s.html |s.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00,20.05.13 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Not backported to 19.11.x Enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to wainuiwitikapark from comment #9)
Not backported to 19.11.x
Enhancement
I would backport it, even if it's an enhancement, it's safe. You may need it at some point, the release_tools scripts are using it now. Same for bug 26621, bug 28386 and bug 28442 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 --- Comment #11 from wainuiwitikapark@catalyst.net.nz --- Backported to 19.11.x for 19.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00,20.05.13 |20.11.00,20.05.13,19.11.19 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394 Ahmed <ahmedsayeed1982@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahmedsayeed1982@yahoo.com --- Comment #12 from Ahmed <ahmedsayeed1982@yahoo.com> --- no longer builds on aarch64 (native build) after updating to glibc-2.33. http://www-look-4.com/services/usb-type-a/ Due to a glibc 2.33 header file change, the file http://the-hunters.org/category/computers/ nat/aarch64-linux-hw-point.c no longer builds on OSes using this version of glibc. https://komiya-dental.com/services/huawei-service/ An enum for PTRACE_SYSEMU is now provided by <sys/ptrace.h>. In the past, PTRACE_SYSEMU was defined only in <asm/ptrace.h>. This is http://www.iu-bloomington.com/property/properties-in-turkey/ what it looks like... In <asm/ptrace.h>: https://waytowhatsnext.com/crypto/cryptocurrency-taxes/ #define PTRACE_SYSEMU 31 http://www.wearelondonmade.com/health/check-ups/ In <sys/ptrace.h>: http://www.jopspeech.com/services/surface-duo/ enum __ptrace_request { http://joerg.li/services/kia-rio-price/ ... PTRACE_SYSEMU = 31, #define PT_SYSEMU PTRACE_SYSEMU ... http://connstr.net/services/mobile-games/ } When <asm/ptrace.h> and <sys/ptrace.h> are both included in a source http://fishingnewsletters.co.uk/category/computers/ file, we run into the following build problem when the former is included before the latter: http://embermanchester.uk/tech/google-drive/ In file included from nat/aarch64-linux-hw-point.c:26: http://www.go-mk-websites.co.uk/category/computers/ /usr/include/sys/ptrace.h:86:3: error: expected identifier before numeric constant 86 | PTRACE_SYSEMU = 31, http://www.slipstone.co.uk/technology/cars-interior/ | ^~~~~~~~~~~~~ (There are more errors after this one too.) http://www.logoarts.co.uk/technology/robot-vacuums/ The file builds without error when <asm/ptrace.h> is included after http://www.mconstantine.co.uk/category/computers/ <sys/ptrace.h>. I found that this is already done in http://www.acpirateradio.co.uk/health/transportation-security/ nat/aarch64-sve-linux-ptrace.h (which is included by nat/aarch64-linux-ptrace.c). http://www.compilatori.com/health/premium-subscription/ A commit for this bug is already on the trunk: https://www.webb-dev.co.uk/computers/crypto-apps/ -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org