[Bug 30556] New: OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Bug ID: 30556 Summary: OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When circulation rules don't allow on shelf holds, the "Place hold" button still appears on the OPAC next to available items. 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record The Place hold button should not appear, but currently, it does. I think this may be related to Bug 3142? I'm not sure... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #1 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 133497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133497&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds holds allowed is on "If all unavailable", the Place hold button is not showed. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 The Minh Luong <the-minh.luong@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the-minh.luong@inlibro.com Attachment #133497|1 |0 is patch| | Attachment #133497|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #2 from The Minh Luong <the-minh.luong@inlibro.com> --- Created attachment 133608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133608&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds holds allowed is on "If all unavailable", the Place hold button is not showed. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |shi-yao.wang@inLibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133608|0 |1 is obsolete| | --- Comment #3 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 134172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134172&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #4 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 134420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134420&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #5 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 134421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134421&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #6 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- The last 2 patches are not directly related to this bug but they should have been there in the first place to not cause any errors when borrowernumber or patron are undefined. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134172|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 134436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134436&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134420|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 134437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134437&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134421|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 134438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134438&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the OPAC details release notes| |page for a record so that | |the "Place hold" button is | |not shown when on shelf | |holds are not allowed (when | |the "On shelf holds | |allowed" circulation and | |fines rule is set to either | |"If any unavailable" or "If | |all unavailable"). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #10 from David Nind <david@davidnind.com> --- I noted when testing that the "Place hold" button is also not displayed when the "If any unavailable" option is selected. I assume that this is OK - I've never really got my head around this setting! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134436|0 |1 is obsolete| | --- Comment #11 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 134617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134617&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134437|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 134619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134619&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134438|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 134620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134620&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134617|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 134621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134621&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to assign yourself to the bug :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20985 --- Comment #16 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- We can probably optimize this bug fix if https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 goes through. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #17 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- This bug fix could be optimized if https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 goes through. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #18 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Sorry, sent the same message twice... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134621|0 |1 is obsolete| | --- Comment #19 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 135395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135395&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Nind from comment #10)
I noted when testing that the "Place hold" button is also not displayed when the "If any unavailable" option is selected. I assume that this is OK - I've never really got my head around this setting!
It's awkward language, it boils down to "If I could walk into the library and each of the items on this record are something I could check out right now, don't allow holds." So if I have 10 items on a record, and all down are able to be checked out, don't allow holds. But, if even one is checked out, allow holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Quick and dirty perf testing, one page load per: 500 Items Pre-patch ISBD: 2.5 MARC: 6.21 Details: 4.51 Post-patch ISBD: 2.84 MARC: 6.15 Details: 5.86 3000 Items Pre-patch ISBD: 6.28 MARC: 25.32 Details: 23.48 Post-patch ISBD: 6.07 MARC: 25.55 Details: 23.51 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- 3000 Items Post-patch, rule = "If any unavailable" ISBD: 27.01 MARC: 44.76 Details: 43.51 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- It appears that this patch definitely has a noticeable effect on page loads at scale. The most immediate blocker at this point is a lack of unit tests for the changes to the Perl modules. Please provide unit tests for the changes to CanBookBeReserved and IsAvailableForItemLevelRequest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #24 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 137065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137065&action=edit Bug 30556: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134619|0 |1 is obsolete| | --- Comment #25 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139289&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134620|0 |1 is obsolete| | --- Comment #26 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139290&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135395|0 |1 is obsolete| | --- Comment #27 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139291&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137065|0 |1 is obsolete| | --- Comment #28 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139292&action=edit Bug 30556: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In your code I see: +my $currentbranch = C4::Context->userenv ? C4::Context->userenv->{branch} : undef; + $is_available = IsAvailableForItemLevelRequest($item, $patron, $currentbranch) + unless $is_available; But when I look at the POD for IsAvailableForItemLevelRequest the third parameter is supposed to be the pick-up location, not the logged-in user's branch: https://git.koha-community.org/Koha-community/Koha/src/commit/9408a443c24a54... my $is_available = IsAvailableForItemLevelRequest( $item_record, $borrower_record, $pickup_branchcode ); I believe this isn't correct. A system might allow you to place a hold for pickup at the item's home library, which might not be the patron's home library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #30 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144429&action=edit Bug 30556: Changing the logged-in user's branch by pick-up location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|shi-yao.wang@inLibro.com |hammat.wele@inlibro.com Status|Failed QA |Needs Signoff CC| |hammat.wele@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139289|0 |1 is obsolete| | --- Comment #31 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147378&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139290|0 |1 is obsolete| | --- Comment #32 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147379&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139291|0 |1 is obsolete| | --- Comment #33 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147380&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139292|0 |1 is obsolete| | --- Comment #34 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147381&action=edit Bug 30556: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144429|0 |1 is obsolete| | --- Comment #35 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147382&action=edit Bug 30556: Changing the logged-in user's branch by pick-up location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #36 from Hammat wele <hammat.wele@inlibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #37 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147441&action=edit Bug 30846: 'If any unavailable' doesn't consider negative notforlan values as unavailable When we set up a circulation rule where 'On shelf holds allowed' is 'If any unavailable' and we have a record with one 'Ordered' item, we cannot place this item on hold. This patch allows placing hold on item with negative not for loan values, when using rule with 'On shelf holds allowed' set to 'If any unavailable' To test: 1. Set up a circulation rule where on shelf holds are not allowed and force the choosing of an item (to facilitate the test) 1.1. Go to Administration > Circulation and fines rules 1.2. In the matrix, add a circulation like this - Patron category: All - Item type: Books - Current checkouts allowed: 10 - Current on-site checkouts allowed: 10 - Loan period: 21 - Holds allowed (total): 10 - Holds allowed (daily): 10 - Holds per record (count): 10 - On shelf holds allowed: If any unavailable - OPAC item level holds: Force 1.3. Click Save 2. Create a record with one 'Ordered' item (or any negative value not for loan status) 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (by default in MARC21: 000, 003, 005, 008, 040, 245, and 942 (942 should be set to Books)) 2.4. Click Save 2.5. Fill out the following item fields - Not for loan: Ordered - Koha item type: Books 2.6. Click Add item 2.7. Click Normal to go to the detailed record 3. Try to place a hold on the 'Ordered' item 3.1. From the detailed record, click OPAC view: Open in new window. --> Note that the 'Place hold' option is not present 4. Add a second 'Available' item 4.1. Back in the staff interface tab with the detailed record, click New > New item 4.2. Make sure the item type is set to Books 4.3. Add a barcode in p 4.4. Click Add item 5. Try again to place a hold on the 'Ordered' item 5.1. Go back to the OPAC tab and refresh the page --> Note that the 'Place hold' option is still not present 6. Check out the available item to a patron 6.1. In the staff interface tab, copy the barcode from the available item 6.2. Go to Patrons 6.3. Click on Search 6.4. Click Check out next to one of the patrons 6.5. Paste the barcode in the box and click Check out 7. Try again to place a hold on the 'Ordered' item 7.1. Go back to the OPAC tab and refresh the page --> Note that the 'Place hold' option is now present 7.2. Click Place hold --> Note that only the checked out item is available to place on hold, if you click Show unholdable items, it will show the Ordered item, but you can't place a hold on it. 8. Apply the patch 9. Go to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is still present 9.1. Click Place hold --> Note that you can now place a hold on the 'Checked out' or the 'Ordered' item. 10. Check in the item to make it available again 10.1. In the staff interface tab, click on 'Show checkouts' button 10.2. Select the Checked out item and click on 'Renew or check in selected items' button. 11. Try again to place a hold on the 'Ordered' item 11.1. Go back to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is still present 11.2. Click Place hold --> Note that only the 'Ordered' item is available to place on hold, if you click Show unholdable items, it will show the Available item and you can't place a hold on it. 12. Delete the available item to keep only the Ordered item 12.1 in the staff interface tab, click on 'Search catalog' and search for the record 12.2 click on 'Edit' then 'Edit items' 12.3 Delete the available item 13. Try to place a hold on the remain 'Ordered' item 13.1 Go back to the OPAC tab and click on the book title right next to 'Place a hold on' checkbox to go back to the record details. --> Note that the 'Place hold' option is present 13.2. Click Place hold --> Note that you can place a hold on the Ordered item. Signed-off-by: Amaury GAU <amaury.gau@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #38 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 147442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147442&action=edit Bug 30846: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147442|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147378|0 |1 is obsolete| | --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 150218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150218&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147379|0 |1 is obsolete| | --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 150219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150219&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147380|0 |1 is obsolete| | --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 150220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150220&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147381|0 |1 is obsolete| | --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 150221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150221&action=edit Bug 30556: (follow-up) Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147382|0 |1 is obsolete| | --- Comment #43 from David Nind <david@davidnind.com> --- Created attachment 150222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150222&action=edit Bug 30556: Changing the logged-in user's branch by pick-up location Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. + return { status => '' } unless $borrowernumber; + return 0 unless $patron; No, you can raise an exception if you want. 2. There is no explanation on the logic changes. Can you detail? 3. Code is duplicated in controller scripts, that feels wrong. We certainly want it in a module, covered by tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|the-minh.luong@inlibro.com |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- See last comment from Joubu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150218|0 |1 is obsolete| | --- Comment #46 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 156188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156188&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150219|0 |1 is obsolete| | --- Comment #47 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 156189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156189&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150220|0 |1 is obsolete| | --- Comment #48 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 156190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156190&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150221|0 |1 is obsolete| | --- Comment #49 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 156191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156191&action=edit Bug 30556: (follow-up) Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150222|0 |1 is obsolete| | --- Comment #50 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 156192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156192&action=edit Bug 30556: Changing the logged-in user's branch by pick-up location Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |hinemoea.viault@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156192|0 |1 is obsolete| | Attachment #156192|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #51 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 156429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156429&action=edit Bug 30556: Fix the call on IsAvailableForItemLevelRequest and CanBookBeReserved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34886 --- Comment #52 from David Nind <david@davidnind.com> --- I'm not getting the expected results for the 'On shelf holds allowed', both before and after the patch is applied. Maybe this is something to do with Bug 34886 - Regression in when hold button appears? Set up: - Changed the circulation and fines rules for all patron categories and item types (basically, just used one rule) - Used Mary Burton as the patron Before the patch is applied, I am getting this behavour: - On shelf holds allowed: Yes . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: can place a hold - On shelf holds allowed: If any unavailable . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: no 'Place hold' option - On shelf holds allowed: If all unavailable . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: no 'Place hold' option After the patch is applied, I am getting this behavour: - On shelf holds allowed: Yes . Not logged in to OPAC: no 'Place hold' option . Logged in to OPAC: can place a hold - On shelf holds allowed: If any unavailable . Not logged in to OPAC: can place a hold . Logged in to OPAC: no 'Place hold' option - On shelf holds allowed: If all unavailable . Not logged in to OPAC: can place a hold . Logged in to OPAC: no 'Place hold' option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily-rose.francoeur@inLibr | |o.com --- Comment #53 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Hi David, I tested the patch with the setup you mentioned, and I didn't obtain the same result as you after applying the patch. Here are the results I obtained: - On-shelf holds allowed: Yes . Not logged in to OPAC: Can place a hold (we don’t have the same result here) . Logged in to OPAC: Can place a hold - On-shelf holds allowed: If any unavailable . Not logged in to OPAC: Can place a hold . Logged in to OPAC: No 'Place hold' option - On-shelf holds allowed: If all unavailable . Not logged in to OPAC: Can place a hold . Logged in to OPAC: No 'Place hold' option I conducted the tests twice and obtained the same results: - First time: I used a notice with only one item. This item had the "Book" itype, wasn't checked out, and had an available status. - Second time: I used a notice with two items. These items had the "Book" itype, were not checked out, and had an available status. Can you describe the notice and the item(s) (itype, status, checked out or not, availability) that you used, and I will attempt to reproduce the issue on my end? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32702 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156188|0 |1 is obsolete| | --- Comment #54 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 157087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157087&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156189|0 |1 is obsolete| | --- Comment #55 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 157088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157088&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156190|0 |1 is obsolete| | --- Comment #56 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 157089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157089&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156191|0 |1 is obsolete| | --- Comment #57 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 157090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157090&action=edit Bug 30556: (follow-up) Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156429|0 |1 is obsolete| | --- Comment #58 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 157091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157091&action=edit Bug 30556: Fix the call on IsAvailableForItemLevelRequest and CanBookBeReserved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #59 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- The patch has been rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #60 from Blou <philippe.blouin@inlibro.com> --- The problem doesn't seem to happen anymore, now that Bug 30846 is on the stack. We can close this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org