[Bug 20016] New: use Modern::Perl in svc scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Bug ID: 20016 Summary: use Modern::Perl in svc scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: authentication bib bib_profile checkouts config/systempreferences import_bib new_bib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 --- Comment #1 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70671&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70671|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 70899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70899&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib https://bugs.koha-community.org/show_bug.cgi?id=20016 Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Jon Knight signed a patch supplied by Zoe Bennett. It looks good to me too. Changing to signed off, since I think that was just a forgotten step. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70899|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71183&action=edit Bug 20016: use Modern::Perl in svc scripts Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib https://bugs.koha-community.org/show_bug.cgi?id=20016 Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |zoebennett1308@gmail.com |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement not backported to stable. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org