[Bug 9268] New: Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Bug ID: 9268 Summary: Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: liz@catalyst.net.nz Scanning in a barcode or an ISBN number in Acquisitions -> new order submits the form unexpectedly if the scanner sends carriage returns. If the carriage return is sent early, an error message is popped, which can be ignored but it's an extra click and it can be confusing to users. To replicate: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * A box pops up saying 'Form not submitted because of the following problem(s) - you must select budget - Quantity must be greater than '0'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I believe this has been fixed under Firefox but not under Chrome, which propagates the event up through the hierarchy of forms on that page. See bug 8557. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 --- Comment #2 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14016&action=edit Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 --- Comment #3 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14017&action=edit Bug 9268 - Followup - Making it work properly in chrome as well To test: (go through the previous test plan on chrome instead of Firefox) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- I should add - I haven't quite figured out how to make it work on the barcode entry field (yet) but at least the ISBN box won't cause the problem in chrome anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14016|0 |1 is obsolete| | Attachment #14017|0 |1 is obsolete| | --- Comment #5 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14018&action=edit Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 --- Comment #6 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Never mind! I found a better way to make it work so it works everywhere. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored --- Comment #7 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Sponsored by: Hauraki District Libraries, New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14018|0 |1 is obsolete| | --- Comment #8 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14064&action=edit Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Sponsored by: Hauraki District Libraries, New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14064|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14328&action=edit [SIGNED-OFF] Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Sponsored by: Hauraki District Libraries, New Zealand Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan in Firefox and Chromium on Ubuntu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch works as expected. It would be great to factorize this code (it appears in 3 tt files). Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |liz@catalyst.net.nz |ity.org | QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14328|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14946&action=edit Bug 9268 - Scanning in barcode or ISBN in Acquisitions -> new order submits the form unexpectedly To Test: * Go to Acquisitions - Manage Orders * Search for a vendor * Click New Basket. * Fill required fields * Press Save. * Click on "From a new (empty) record" * Type in title Private Oz, Author Patterson, James. * Scan (or type) ISBN - 9781864711875. * (If not scanning, PRESS ENTER HERE) * Nothing should happen. Form should not be submitted, no error message should appear. Sponsored by: Hauraki District Libraries, New Zealand Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan in Firefox and Chromium on Ubuntu. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9507 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org