[Bug 24510] New: When Placing a Hold, cursor doesn't focus on Patron Name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Bug ID: 24510 Summary: When Placing a Hold, cursor doesn't focus on Patron Name Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To reproduce: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. In 19.05, the cursor does go to the Patron Name during this process and that makes sense from a workflow standpoint. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 97887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97887&action=edit Bug 24510: Add focus to Patron/club input TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97887|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97922&action=edit Bug 24510: Add focus to Patron/club input Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What is the purpose of the test? if ( $(".focus").is(":visible") ) I do not understand your patch, neither why it works. I have the feeling that it is not the correct way to do what you want. We already have .focus in this DOM (the header search), and the same .focus() applied on them (in staff-global.js). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CCing Owen, maybe he will know what's going on here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99658&action=edit Bug 24510: [Alternate] When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99658|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 99659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99659&action=edit Bug 24510: [Alternate] When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99659|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 99660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99660&action=edit Bug 24510: [Alternate] When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97922|0 |1 is obsolete| | Attachment #99660|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99661&action=edit Bug 24510: Add focus to Patron/club input Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99662&action=edit Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99663&action=edit Bug 24510: Code cleaning Additional test plan: Create 3 clubs: abc adf axy place a hold for on of those club, search for a club 'a' you will get the focus on the "Clubs" tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99662|0 |1 is obsolete| | Attachment #99663|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99665&action=edit Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99666&action=edit Bug 24510: Code cleaning Additional test plan: Create 3 clubs: abc adf axy place a hold for on of those club, search for a club 'a' you will get the focus on the "Clubs" tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lucas, I re-added your signoff to Owen's patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When Placing a Hold, cursor |When placing a hold, cursor |doesn't focus on Patron |doesn't focus on patron |Name |name CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am getting a QA test tool fail here, please check: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL filters missing_filter at line 982 ( active: [% active %],) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100733&action=edit Bug 24510: Add missing filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99661|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100827&action=edit Bug 24510: Add focus to Patron/club input Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99665|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100828&action=edit Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99666|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100829&action=edit Bug 24510: Code cleaning Additional test plan: Create 3 clubs: abc adf axy place a hold for on of those club, search for a club 'a' you will get the focus on the "Clubs" tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100733|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100830&action=edit Bug 24510: Add missing filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | CC| |joy@bywatersolutions.com --- Comment #21 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org