[Bug 31203] New: Cronjobs should log completion as well as logging begin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Bug ID: 31203 Summary: Cronjobs should log completion as well as logging begin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Currently our cronjobs call cronlogaction when they begin We should add a second call: cronlogaction({done => 1}); To indicate when a job has completed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- 100% yes please -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137960&action=edit Bug 31203: Alter cronlogaction to take a hash and pass PID as object for log This patch simply changes the routine to expect a hashref, now info and pid can be passed through for logging -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137961&action=edit Bug 31203: POC advance_notices This patch proposes a new standard for cronlogaction We copy @ARGV into a space separated string, then pass this and the PID to cronlogaction At the end of the script we add a call with info "COMPLETED" To test: 1 - Apply patch 2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c 3 - sudo koha-mysql kohadev 4 - SELECT * FROM action_logs WHERE interface="CRON"; 5 - Note start and completion logged 6 - Note command line arguments included in info If this looks good I will copy this pattern to the other cronjobs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137960|0 |1 is obsolete| | Attachment #137961|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137962&action=edit Bug 31203: Alter cronlogaction to take a hash This patch simply changes the routine to expect a hashref for info and to log the PID as object in action logs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137963&action=edit Bug 31203: POC advance_notices This patch proposes a new standard for cronlogaction We copy @ARGV into a space separated string, then pass this to cronlogaction At the end of the script we add a call with info "COMPLETED" To test: 1 - Apply patch 2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c 3 - sudo koha-mysql kohadev 4 - SELECT * FROM action_logs WHERE interface="CRON"; 5 - Note start and completion logged 6 - Note command line arguments included in info If this looks good I will copy this pattern to the other cronjobs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137983&action=edit Bug 31203: Add End action to cronjobs and log viewer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nick, should this be NSO? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138695&action=edit Bug 31203: Alter other cronjobs that currenlty use cronlogaction Added command line ooption logging and completion logging where cronlogaction was already imported. We should probably standardize all cronjobs, but this is a start One cron didn't log on confirm, likely we need to update all crons to log if confirm, and possibly not log if running in test mode? Another bug as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
Nick, should this be NSO?
Added patch to adjust other crons, NSO now ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK... playing devils advocate here.. Do we really need/want this in the action_logs at all? I suppose cronlogaction has precedent.. but whose actually interested in this output? One could just set the cron daemon to log level 2 and then use rsyslog to track cron start and finish times? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #10)
OK... playing devils advocate here..
Do we really need/want this in the action_logs at all? I suppose cronlogaction has precedent.. but whose actually interested in this output?
One could just set the cron daemon to log level 2 and then use rsyslog to track cron start and finish times?
We already log the running, this puts information about the completion into the hands of the the librarians, and not the system administrators. If a patron doesn't get an email, or a fine doesn't get charged, knowing the job completed helps the librarian determine whether it might be Koha settings or a cron issue Extending the completion log to include optional verbosity - how many emails sent, how may items renewed, transfers scheduled, etc. is a next step after this - to provide useful feedback for librarians -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #12 from Liz Rea <wizzyrea@gmail.com> --- Librarians desperately want this. We have had many requests for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137962|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 140743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140743&action=edit Bug 31203: Alter cronlogaction to take a hash This patch simply changes the routine to expect a hashref for info and to log the PID as object in action logs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137963|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 140744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140744&action=edit Bug 31203: POC advance_notices This patch proposes a new standard for cronlogaction We copy @ARGV into a space separated string, then pass this to cronlogaction At the end of the script we add a call with info "COMPLETED" To test: 1 - Apply patch 2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c 3 - sudo koha-mysql kohadev 4 - SELECT * FROM action_logs WHERE interface="CRON"; 5 - Note start and completion logged 6 - Note command line arguments included in info If this looks good I will copy this pattern to the other cronjobs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137983|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 140745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140745&action=edit Bug 31203: Add End action to cronjobs and log viewer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138695|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 140746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140746&action=edit Bug 31203: Alter other cronjobs that currenlty use cronlogaction Added command line ooption logging and completion logging where cronlogaction was already imported. We should probably standardize all cronjobs, but this is a start One cron didn't log on confirm, likely we need to update all crons to log if confirm, and possibly not log if running in test mode? Another bug as well Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #17 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Enable CronjobLog system preference. 2. Follow test plan in patch Bug 31203: POC advance_notices. 3. Check the log viewer in the staff interface - it should show separate entries for Run and End actions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #18 from David Nind <david@davidnind.com> --- FYI, when applying the patch it showed whitespace errors/warnings: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31203: Alter cronlogaction to take a hash Applying: Bug 31203: POC advance_notices Applying: Bug 31203: Add End action to cronjobs and log viewer Applying: Bug 31203: Alter other cronjobs that currenlty use cronlogaction .git/rebase-apply/patch:257: trailing whitespace. GetOptions( warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/datatables.js M misc/cronjobs/automatic_renewals.pl M misc/cronjobs/batch_anonymise.pl M misc/cronjobs/fines.pl M misc/cronjobs/overdue_notices.pl M misc/cronjobs/patron_emailer.pl M misc/cronjobs/serialsUpdate.pl M misc/cronjobs/staticfines.pl .git/rebase-apply/patch:257: trailing whitespace. GetOptions( .git/rebase-apply/patch:214: new blank line at EOF. + .git/rebase-apply/patch:385: new blank line at EOF. + .git/rebase-apply/patch:401: new blank line at EOF. + .git/rebase-apply/patch:424: new blank line at EOF. + warning: squelched 13 whitespace errors warning: 18 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/staticfines.pl Auto-merging misc/cronjobs/serialsUpdate.pl Auto-merging misc/cronjobs/patron_emailer.pl Auto-merging misc/cronjobs/overdue_notices.pl Auto-merging misc/cronjobs/fines.pl Auto-merging misc/cronjobs/batch_anonymise.pl Auto-merging misc/cronjobs/automatic_renewals.pl Auto-merging koha-tmpl/intranet-tmpl/prog/js/datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140743|0 |1 is obsolete| | Attachment #140744|0 |1 is obsolete| | Attachment #140745|0 |1 is obsolete| | Attachment #140746|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140980&action=edit Bug 31203: Alter cronlogaction to take a hash This patch simply changes the routine to expect a hashref for info and to log the PID as object in action logs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140981&action=edit Bug 31203: POC advance_notices This patch proposes a new standard for cronlogaction We copy @ARGV into a space separated string, then pass this to cronlogaction At the end of the script we add a call with info "COMPLETED" To test: 1 - Apply patch 2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c 3 - sudo koha-mysql kohadev 4 - SELECT * FROM action_logs WHERE interface="CRON"; 5 - Note start and completion logged 6 - Note command line arguments included in info If this looks good I will copy this pattern to the other cronjobs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140982&action=edit Bug 31203: Add End action to cronjobs and log viewer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140983&action=edit Bug 31203: Alter other cronjobs that currenlty use cronlogaction Added command line ooption logging and completion logging where cronlogaction was already imported. We should probably standardize all cronjobs, but this is a start One cron didn't log on confirm, likely we need to update all crons to log if confirm, and possibly not log if running in test mode? Another bug as well Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + logaction( 'CRONJOBS', 'Run', $$, $loginfo ) if C4::Context->preference('CronjobLog'); Hmm. The PID as the object number. We should not do that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git grep -l logaction | xargs prove db_dependent/Illrequest/Logger.t ..... ok db_dependent/Koha/ActionLogs.t ....... ok db_dependent/Koha/Patron/Messages.t .. ok db_dependent/Log.t ................... ok All tests successful. Files=4, Tests=21, 10 wallclock secs ( 0.05 usr 0.01 sys + 7.82 cusr 1.03 csys = 8.91 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Running advance_notices: Can't locate PatternLayout.pm in @INC Whats happening here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- | 892 | 2022-09-30 08:43:33 | 0 | CRONJOBS | Run | 190998 | misc/cronjobs/cleanup_database.pl -confirm -v -m | cron | cleanup_database.pl | | 893 | 2022-09-30 08:43:33 | 0 | CRONJOBS | End | 190998 | misc/cronjobs/cleanup_database.pl COMPLETED | cron | cleanup_database.pl | Should we replace Run now with Start to be more clear ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + [% FOREACH actx IN [ 'ADD' 'DELETE' 'MODIFY' 'ISSUE' 'RETURN' 'RENEW' 'CREATE' 'CANCEL' 'FILL' 'SUSPEND' 'RESUME' 'ADDCIRCMESSAGE' 'DELCIRCMESSAGE' 'STATUS_CHANGE' 'PATRON_NOTICE' 'CHANGE PASS' 'Run' 'End' 'EDIT_MAPPINGS' 'RESET_MAPPINGS' 'ADD_BASKET' 'MODIFY_BASKET' 'MODIFY_BASKET_HEADER' 'MODIFY_BASKET_USERS' 'CLOSE_BASKET' 'APPROVE_BASKET' 'REOPEN_BASKET' 'CANCEL_ORDER' 'CREATE_ORDER' 'MODIFY_ORDER' 'CREATE_INVOICE_ADJUSTMENT' 'UPDATE_INVOICE_ADJUSTMENT' 'DELETE_INVOICE_ADJUSTMENT' 'RECEIVE_ORDER' 'MODIFY_BUDGET' 'MODIFY_FUND' 'CREATE_FUND' 'DELETE_FUND' 'OVERDUE' 'EXPIRE' ] %] Seems to work, although I expected commas. It is a bit weird that we have lower case Run and End here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + console.log(Array.isArray(options.embed)); debugging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Just needs a bit of polishing. See earlier comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141128&action=edit Bug 31203: (follow-up) Remove stray debug statement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #24)
Hmm. The PID as the object number. We should not do that. This is to allow matching the Run to End actions for a single run - what would you prefer?
(In reply to Marcel de Rooy from comment #26)
Running advance_notices: Can't locate PatternLayout.pm in @INC Whats happening here?
I don't recreate - custom logging setup? (In reply to Marcel de Rooy from comment #28)
+ [% FOREACH actx IN [ 'ADD' 'DELETE' 'MODIFY' 'ISSUE' 'RETURN' 'RENEW' 'CREATE' 'CANCEL' 'FILL' 'SUSPEND' ... Seems to work, although I expected commas. Following pattern with my patch - feel free to provide a follow-up
It is a bit weird that we have lower case Run and End here. Following the current status for this - feel free to provide a follow-up
(In reply to Marcel de Rooy from comment #29)
+ console.log(Array.isArray(options.embed)); debugging
Removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #32)
(In reply to Marcel de Rooy from comment #24)
Hmm. The PID as the object number. We should not do that. This is to allow matching the Run to End actions for a single run - what would you prefer?
Well, I think we have more inappropriate use of that column. So I can live with that ;)
(In reply to Marcel de Rooy from comment #26)
Running advance_notices: Can't locate PatternLayout.pm in @INC Whats happening here?
I don't recreate - custom logging setup?
Not sure what it is. But my new container doesnt complain anymore..
(In reply to Marcel de Rooy from comment #28)
+ [% FOREACH actx IN [ 'ADD' 'DELETE' 'MODIFY' 'ISSUE' 'RETURN' 'RENEW' 'CREATE' 'CANCEL' 'FILL' 'SUSPEND' ... Seems to work, although I expected commas. Following pattern with my patch - feel free to provide a follow-up
It is a bit weird that we have lower case Run and End here. Following the current status for this - feel free to provide a follow-up
There is a limit :)
(In reply to Marcel de Rooy from comment #29)
+ console.log(Array.isArray(options.embed)); debugging
Removed
Good -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140980|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141311&action=edit Bug 31203: Alter cronlogaction to take a hash This patch simply changes the routine to expect a hashref for info and to log the PID as object in action logs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140981|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141312&action=edit Bug 31203: POC advance_notices This patch proposes a new standard for cronlogaction We copy @ARGV into a space separated string, then pass this to cronlogaction At the end of the script we add a call with info "COMPLETED" To test: 1 - Apply patch 2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c 3 - sudo koha-mysql kohadev 4 - SELECT * FROM action_logs WHERE interface="CRON"; 5 - Note start and completion logged 6 - Note command line arguments included in info If this looks good I will copy this pattern to the other cronjobs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140982|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141313&action=edit Bug 31203: Add End action to cronjobs and log viewer Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140983|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141314&action=edit Bug 31203: Alter other cronjobs that currenlty use cronlogaction Added command line ooption logging and completion logging where cronlogaction was already imported. We should probably standardize all cronjobs, but this is a start One cron didn't log on confirm, likely we need to update all crons to log if confirm, and possibly not log if running in test mode? Another bug as well Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141128|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141315&action=edit Bug 31203: (follow-up) Remove stray debug statement Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #40 from Magnus Enger <magnus@libriotech.no> --- This is a problem in 21.11. Cronjobs log Action = Run twice, and the Info shows e.g.: /path/to/overdue_notices.pl HASH(0x556458941310) Any chance of a backport? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33649 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33649 [Bug 33649] Fix use of cronlogaction in process_message_queue.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/678 Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org