[Bug 16586] New: Koha Plugins: Limit results of GetPlugins by metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Bug ID: 16586 Summary: Koha Plugins: Limit results of GetPlugins by metadata Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51771&action=edit Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata It would be helpful if we could find a plugin based on some metadata tag as returned by the plugin. This extends the use of GetPlugins that already supports searching on method. GetPlugins is used in: admin/edi_accounts.pl, plugins/plugins-home.pl and tools/stage-marc-import.pl. The changes in these three scripts are minimal and just related to parameter passing. Test t/db_dependent/Plugins.t includes another test for GetPlugins. In this regard a metadata tag has been added to t/Koha/Plugins/Test.pm. NOTE: This adjustment will also be used in a redesign for bug 15545. Test plan: Run t/db_dependent/Plugins.t. Enable pref UseKohaPlugins and config var enable_plugins. Go to plugins-home.pl. Verify that it still lists your plugins. Bonus: Check edi_accounts or stage-marc-import.pl if you have a working plugin for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 [Bug 15545] Optionally require notes when placing a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51771|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 53544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53544&action=edit [SIGNED-OFF] Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata It would be helpful if we could find a plugin based on some metadata tag as returned by the plugin. This extends the use of GetPlugins that already supports searching on method. GetPlugins is used in: admin/edi_accounts.pl, plugins/plugins-home.pl and tools/stage-marc-import.pl. The changes in these three scripts are minimal and just related to parameter passing. Test t/db_dependent/Plugins.t includes another test for GetPlugins. In this regard a metadata tag has been added to t/Koha/Plugins/Test.pm. NOTE: This adjustment will also be used in a redesign for bug 15545. Test plan: Run t/db_dependent/Plugins.t. Enable pref UseKohaPlugins and config var enable_plugins. Go to plugins-home.pl. Verify that it still lists your plugins. Bonus: Check edi_accounts or stage-marc-import.pl if you have a working plugin for that. Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53544|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53691&action=edit Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata It would be helpful if we could find a plugin based on some metadata tag as returned by the plugin. This extends the use of GetPlugins that already supports searching on method. GetPlugins is used in: admin/edi_accounts.pl, plugins/plugins-home.pl and tools/stage-marc-import.pl. The changes in these three scripts are minimal and just related to parameter passing. Test t/db_dependent/Plugins.t includes another test for GetPlugins. In this regard a metadata tag has been added to t/Koha/Plugins/Test.pm. NOTE: This adjustment will also be used in a redesign for bug 15545. Test plan: Run t/db_dependent/Plugins.t. Enable pref UseKohaPlugins and config var enable_plugins. Go to plugins-home.pl. Verify that it still lists your plugins. Bonus: Check edi_accounts or stage-marc-import.pl if you have a working plugin for that. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53692&action=edit Bug 16586: Simplify code using none Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53692|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53717&action=edit Bug 16586: [QA Follow-up] Add test for two metadata conditions Run the test and see.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53718&action=edit Bug 16586: Simplify code using none Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4)
Created attachment 53692 [details] [review] Bug 16586: Simplify code using none
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thx for QAing. I have the impression that your follow-up slightly changes behavior. It appears to be not as simple after all :) Check the code for the situation that %$req_metadata is empty. The additional unit test in my follow-up will prove it for you: run this test with and without your last patch. Please correct.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7)
Check the code for the situation that %$req_metadata is empty. Sorry this line makes no sense. Just run the test..
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53718|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53747&action=edit Bug 16586: Simplify code using none Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended this patch: Replaced none by any. Exists test adjusted. This effectively makes the test pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53747|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 53748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53748&action=edit Bug 16586: [QA Follow-up] Simplify code Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended this patch: Replaced none by any. Exists test adjusted. This effectively makes the test pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7)
(In reply to Jonathan Druart from comment #4)
Please correct.. Done
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marcel, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Now we could find a plugin release notes| |based on some metadata tag | |as returned by the plugin. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org