[Bug 23076] New: Include OpacUserJS on OPAC maintenance page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Bug ID: 23076 Summary: Include OpacUserJS on OPAC maintenance page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- At the moment it's not possible to use OpacUserJS with the OPAC maintenance page. It would be nice to have that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|17.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90414&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23078 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90414|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 90430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90430&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90430|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 90431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90431&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |templates to use JavaScript | |included the OPACUserJS | |system preference (it now | |uses the 'Koha.Preference' | |syntax in the global | |include file). This makes | |the data available in | |templates, such as the OPAC | |maintenance page. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #4 from David Nind <david@davidnind.com> --- Should the title now be 'Include OpacUserJS in templates'? Not understanding the nuts and bolts of this, my limited understanding as that the OPAC maintenance page is just one place it can be used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #5 from David Nind <david@davidnind.com> --- Also, have I got the text for the release notes right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #4)
Should the title now be 'Include OpacUserJS in templates'?
OpacUserJS was available to almost all templates before this patch. I'm not sure if the maintenance page was the only one which lacked it. My patch ensures that the bug affecting the maintenance page won't affect other pages for the same reason. It would be safer to keep the title as-is. The release notes should be indicate that this is a bug fix affecting the OPAC maintenance page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This fix allows the OPAC release notes|templates to use JavaScript |maintenance page to use |included the OPACUserJS |JavaScript included in the |system preference (it now |OPACUserJS system |uses the 'Koha.Preference' |preference. |syntax in the global | |include file). This makes | |the data available in | |templates, such as the OPAC | |maintenance page. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #7 from David Nind <david@davidnind.com> --- Thnaks Owen! I've updated the text for the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90431|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90445&action=edit Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you for the quick fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23076 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org