[Bug 35658] New: Embedding broken in /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Bug ID: 35658 Summary: Embedding broken in /patrons/:patron_id/holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com CC: tomascohen@gmail.com Bug 34333 added the ability to embed cancellation requests information on the holds endpoint, but the `collectionFormat` attribute got misaligned, making the feature unusable. This is hard to catch. Steps to reproduce: 1. Open your favourite REST tool 2. Make this request: GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons/42/holds x-koha-embed: cancellation_requested => SUCCESS: Probably empty result, but not an error 3. Make this change: $ git diff diff --git a/api/v1/swagger/paths/patrons_holds.yaml b/api/v1/swagger/paths/patrons_holds.yaml index e8e1335a87d..c70d3359c41 100644 --- a/api/v1/swagger/paths/patrons_holds.yaml +++ b/api/v1/swagger/paths/patrons_holds.yaml @@ -24,6 +24,7 @@ type: string enum: - cancellation_requested + - pickup_library collectionFormat: csv produces: - application/json 4. Restart plack: $ ktd --shell k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: Same thing 6. Amend the request like this: GET http://kohadev-intra.myDNSname.org:8081/api/v1/patrons/42/holds x-koha-embed: cancellation_requested,pickup_library => FAIL: You get this, which is weird because it matches exactly what's in the x-koha-embed `enum`: { "errors": [ { "message": "Not in enum list: cancellation_requested, pickup_library.", "path": "/x-koha-embed/0" } ], "status": 400 } This is related to bug 35614. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34333 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35614 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 [Bug 34333] Add cancellation request information embed option to the holds endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 160353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160353&action=edit Bug 35658: Fix misaligned collectionFormat in patron_holds.yaml This patch fixes a silly typo. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Embedding broken in |Typo in |/patrons/:patron_id/holds |/patrons/:patron_id/holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Severity|normal |major --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Upping severity, I lost hours on this... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, holidays got in the way - it's next on my 'push list' already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658 Bug 35658 depends on bug 34333, which changed state. Bug 34333 Summary: Add cancellation request information embed option to the holds endpoint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org