http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20938&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20940&action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20942&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20944&action=edit Bug 10855: FIX: Add additional fields for closed subscriptions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10855: Update database entry Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Patch failed at 0001 Bug 10855: Update database entry The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20937|0 |1 is obsolete| | Attachment #20938|0 |1 is obsolete| | Attachment #20939|0 |1 is obsolete| | Attachment #20940|0 |1 is obsolete| | Attachment #20941|0 |1 is obsolete| | Attachment #20942|0 |1 is obsolete| | Attachment #20943|0 |1 is obsolete| | Attachment #20944|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21184&action=edit Bug 10855: Add the new package Koha::AdditionalField -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21186&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21188&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21190&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #18 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10855: Update database entry Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 10855: Update database entry The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21663&action=edit Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21185|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22050&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21187|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22052&action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21189|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22054&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21191|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22056&action=edit Bug 10855: FIX: Add additional fields for closed subscriptions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22056|0 |1 is obsolete| | Attachment #22057|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22359&action=edit Bug 10855: FIX: Add additional fields for closed subscriptions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10914 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Paola Rossi <paola.rossi@cineca.it> --- against master 3.13.00.034: Applying: Bug 10855: New fields on adding/updating a subscription Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging serials/subscription-detail.pl Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in serials/subscription-add.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging C4/Serials.pm CONFLICT (content): Merge conflict in C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 Bug 10855: New fields on adding/updating a subscription So I pass tha patch to "Failed QA" status. NB. Update database entry needs to be rebased too. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22049|0 |1 is obsolete| | Attachment #22050|0 |1 is obsolete| | Attachment #22051|0 |1 is obsolete| | Attachment #22052|0 |1 is obsolete| | Attachment #22053|0 |1 is obsolete| | Attachment #22054|0 |1 is obsolete| | Attachment #22055|0 |1 is obsolete| | Attachment #22359|0 |1 is obsolete| | Attachment #22360|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22600&action=edit Bug 10855: Add the new package Koha::AdditionalField -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22602&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22604&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22606&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22608&action=edit Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22601|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22616&action=edit Bug 10855: Update database entry -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #46 from Paola Rossi <paola.rossi@cineca.it> --- against master 3.13.00.042: Applying: Bug 10855: New fields on adding/updating a subscription Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging serials/subscription-detail.pl Auto-merging serials/subscription-add.pl Auto-merging C4/Serials.pm CONFLICT (content): Merge conflict in C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 Bug 10855: New fields on adding/updating a subscription So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22605|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22699&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22607|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22701&action=edit Bug 10855: FIX: Add additional fields for closed subscriptions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22616|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22703&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #53 from Paola Rossi <paola.rossi@cineca.it> --- The patches are applied well against 3.13.00.042. Test plan "prove t/db_dependent/AdditionalField.t" results in a FAIL: t/db_dependent/AdditionalField.t .. 1/34 DBD::mysql::st execute failed: Column 'status' cannot be null at /var/root-koha/bug-10855/C4/Serials.pm line 1501. DBD::mysql::st execute failed: Column 'status' cannot be null at /var/root-koha/bug-10855/C4/Serials.pm line 1501. # Looks like you planned 34 tests but ran 20. # Looks like your test exited with 255 just after 20. t/db_dependent/AdditionalField.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/34 subtests Test Summary Report ------------------- t/db_dependent/AdditionalField.t (Wstat: 65280 Tests: 20 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 34 tests but ran 20. Files=1, Tests=20, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.37 cusr 0.16 csys = 0.55 CPU) Result: FAIL So I pass the patch to "Failed QA" status. NB. In my test case, af2 is 245, and the title of the subscribed notice is "Bulletin". Testing new fields on adding/updating a subscription, the af2 field is not filled with the specified marc field of the notice, i.e. there is no "Bulletin" on the left of the sentence "This value will be filled with the 245 subfield of the selected biblio.". Afterwards I set af2 to 245a and try again, but yet nothing appears. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #55 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #53)

NB. In my test case, af2 is 245, and the title of the subscribed notice is "Bulletin". Testing new fields on adding/updating a subscription, the af2 field is not filled with the specified marc field of the notice, i.e. there is no "Bulletin" on the left of the sentence "This value will be filled with the 245 subfield of the selected biblio.". Afterwards I set af2 to 245a and try again, but yet nothing appears.

Last patch fixes the UT. You have to save your subscription for filling the value linked to a marc field. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #57 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #56)

On the contrary, searching from the bottom of the columns works bad: nothing is found (not even the library!) in the various columns. Except in the last column (the fourth added field, in my test case): everything is always found whatever I write (KO).

Could you confirm the filters work on master? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #59 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #58)

Paola, I find a bug on datatables filters (bug 11205). It is not introduced by these patches but maybe it will fix your issue.

Thanks, Jonathan. Applying of 11205 is OK. In subscriptions' advanced search, yes, bug 11205 fixes the problem. Now the filters at the bottom of columns such as "ISSN", "Title", "Library", "Expiration date", work well. Staying that no value is displayed in the new columns of the table [so nor the description neither the code can be seen], nothing is found when I use the filters at the bottom of these columns. In Claims, no, bug 11205 doesn't fix the problem. The use of filters at the bottom of columns such as "Vendor", "Library", "Title", "Issue number", "Status", "af1", always results in a "No matching records found" answer. When I use the filter "From" and "To", the selection is nearby OK (range [x,y] selects "Since"' days between [x+1,y-1]). At the bottom of the table, whereas the "Select CSV profile" is only one ("issues to claim"), selecting "Download selected claims" always results in the error: "Please select at least one item to export". But no checkbox is displayed in the whole page in my test case. about comment 57: The master 042 has not filters in CLAIMS' table. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #61 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22769&action=edit Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #64 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #63)

3) YES_NO,"NO",finds everything and looses the selection in form Good catch! If the value of the authorised values is 0, the filter don't work. I will provide a new followup.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #65 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22869&action=edit Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #66) Hello Paola,

This last patch is wrong in searching: only modified subscriptions are found now. On the contrary, until now, advanced search found either modified subscriptions or not yet modified subscriptions.

I am not sure to understand. You said a subscription does not appear on searching on additional fields if the subscription does not have an additional fields? If yes, it is normal, you have to edit a subscription for setting these fields. Maybe could we imagine a script for automatically filling them.

A) there is an old "Advanced search" tab on the left over "Claims", on cgi-bin/koha/serials/serials-home.pl, whose form shows searchfields like "Supplier", "Branch", "EAN" (?). In the new form for advanced search they are "Vendor", "Library". I think you'd better delete the "old" tab.

Yes, I will remove it.

B) there is an abnormal termination in modifying subscription on /cgi-bin/koha/serials/subscription-add.pl. It occurs when an additional mark field has been added, but it's an error, such as the non-existent 022$b. Koha sends this error message: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107.

Confirmed, will be fix.

When a non-existent mark field is not a new one, but it's added modifying another existent mark field by Action "Edit", modifying the subscription Koha puts no value in the wrong additional field without sending error message.

Could you detail please, I don't reproduce this issue. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23053&action=edit Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #70 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #68)

Created attachment 23052 [details] [review] Bug 10855: Remove the advanced serial search box on the serial home page

thanks, the patch is OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #72 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #67)

(In reply to Paola Rossi from comment #66)

Hello Paola,

[...] you have to edit a subscription for setting these fields. Maybe could we imagine a script for automatically filling them.

a script for automatically filling "mark" additional fields, and filling "category" additional fields with a value chosen among the available ones. Perhaps it could be a script that a user can use or not, depending on the case. And what about adding a further option "missing value" for every additional search field of the form on the left? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl --- Comment #74 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- Hello Jonathan, First - thank you very much for those patches; I really like the concept. I'm currently trying to extend/adapt your solution for another table (aqorders), as suggested in here: [url]http://www.mail-archive.com/koha-devel@lists.koha-community.org/msg05550.html[/url] . So far it's going fine, almost working now. Here and there I'm encountering some (minor) issues, though: 1) Methods in Koha/AdditionalField.pm are taking 'tablename' as an argument, but they are occasionally called with 'table' instead (in patch 22700/Search.pm, 22699/serials-search.pl, 22698, ..) which is silently ignored by package methods. This problem is only starting to manifest itself if there are additional fields for 2+ different tables being used. 2) Column 'value' in table additional_field_values is created (patch 22703) with utf8_bin collation (but only in installer/data/mysql/updatedatabase.pl, not in the installer/data/mysql/kohastructure.sql ?). I wonder if this is intentional (to make it case-sensitve)? 3) Any chances to support/allow arbitrary field names (with non-ascii characters, spaces etc.)? That will probably require an extra column (e.g. "label") in additional_fields table (?). 4) If there are non-asci / uft-8 characters involved (anywhere in the objects returned from AdditionalField.pm - in cases when offending objects are further processed with C4::Templates->output), result WWW page is prone to be garbled (partially double-encoded). This problem is similar to bug 11290; it happens because output()/utf8_arrayref()/utf8_hashref() in Templates.pm do not know what to do with blessed hashrefs - if ref() doesn't return HASH or ARRAY, they wrongly assume it's a scalar.. Like for bug 11290, adding bunch of ' |html_entity' to templates does work as an workaround for this problem, but I'm wondering if we shouldn't actually fix Templates.pm instead, that would be better/more general solution (?). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22703|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23142&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #78 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- Something seems to be not quite right with serials/serials-search.pl. When I'm searching subscriptions using regular fields - leaving additional fields inputs empty / set to 'All' for authorized ones, I'm allways getting 0 search results. This error seems to be related to patch 22869 (added define () in line 79). After changing it this way: 79c79,80 < if ( defined ( my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter') ) ) { ---

my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter'); if ( defined( $filter_value ) && $filter_value ne '' ) {

searching works again like it should. I'm not sure if that may be a proper fix, but it corrected this particular problem. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22701|0 |1 is obsolete| | Attachment #22702|0 |1 is obsolete| | Attachment #22722|0 |1 is obsolete| | Attachment #22768|0 |1 is obsolete| | Attachment #22769|0 |1 is obsolete| | Attachment #22869|0 |1 is obsolete| | Attachment #23052|0 |1 is obsolete| | Attachment #23053|0 |1 is obsolete| | Attachment #23142|0 |1 is obsolete| | Attachment #23143|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23301&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #82 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jacek Ablewicz from comment #78) Hello Jacek, I squashed all fixes into one.

79c79,80 < if ( defined ( my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter') ) ) { ---

...

my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter'); if ( defined( $filter_value ) && $filter_value ne '' ) {

searching works again like it should. I'm not sure if that may be a proper fix, but it corrected this particular problem.

Yep, it is fine. It is included in the squashed patch. (In reply to Jacek Ablewicz from comment #79)

It was enough, no need to extend additional_fields table.. Also, in case extra fields are really needed, one can always add additional fields to additional_fields using Koha::AdditionalFields ;).

It would be fun but I discourage you to do that :)

Yet subscription-add.* script & template are (?) still using field name for <input name=""> etc. isntead of field id - that's where I encountered aftermentioned problems. Another possibility is that while applying patches I simply may have missed one (or two)..

Yes, good catch. Fixed in the last patch too. Thank you very much for testing! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #85 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23595&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #87 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23597&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #89 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23599&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #91 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23601&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #93 from Paola Rossi <paola.rossi@cineca.it> --- I test the patch against master 3.15.00.006. The 8-th patch "Update database entry" needs to be rebased. The following errors occur. So I pass the patch to "Failed QA" status. I add some searchable additional fields, in particular these ones: 022$a category NOT_LOAN category CCODE Using advanced "Search subscription", I see the following 2 errors: S1) My subscription' NOT_LOAN-category-additional-field value is "Ordered" (code "-1" in Administration Authorized values' table); choosing "NOT_FOR_LOAN" (code "1") in the search field in the left column, the list shows the subscription. S2) My subscription' CCODE-category-additional-field value is "Non Fiction" (code "NFIC"); choosing "Fiction" (code "FIC") in the search field in the left column, the list shows the subscription. The string "FIC" is a substring of string "NFIC", as well as the string "1" is a substring of "-1". So the error could be that search matches codes of values of the categories in a "contains" way, instead of an "exactly =" way. The error could occur matching the codes, not the descriptions. A counterexample is this of category "LOST": description "Lost" is a substring of description "Lost and Paid For". The corresponding codes are "1" and "3", mutually distinct strings. S3 OK) searching "Lost", the subscription whose additional value is set to "Lost and Paid for" is not found. Errors filtering at the bottom of the columns of the result table (columns of additional searchable fields): F1) My subscription' ISSN-marc-additional-field value is 12345678; writing 12345678 in the filter at the bottom of the column, the list of subscriptions becomes null. F2) My subscription' NOT_LOAN-category-additional-field value is "Ordered"; writing "Ordered" in the filter at the bottom of the column, the list of subscriptions becomes null. F3) Using every filter at the bottom of the columns of the additional searchable fields, the list becomes null. F4 OK) On the contrary, using the filters at the bottom of the fields that are not additional the list is filtered OK. [I use FireFox 25.0.1] NB1. A form in the left column of the page is often named "Filter" in koha. The subscription searching is named "Search" there. NB2. Before patching the zero case, all the subscriptions were found by advanced search: either the ones modified with additional fields filled, or the ones not yet modified whose additional fields are therefore still unset. After patching the zero case, advanced search found only the modified subscriptions. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #94 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23774&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #96 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #93) Paola, I submitted 2 new patches: The first one fixes the issue on the exact match when a field is linked to an authorised value. The second one fixes the filter issue (bad conflict merge).

NB1. A form in the left column of the page is often named "Filter" in koha. The subscription searching is named "Search" there.

Not introduced by this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23602|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23961&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23774|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23963&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #102 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #97)

Search) The form in the left column of the page keeps the current search values only for non-additional fields. Every time the user selects "Search", the search values currently chosen for the additional searchable fields are lost or ruined. In case of category additional fields, the current search values are lost, reset to "ALL" every time the user selects "Search". In case of marc additional fields, the current search values are set to a Hash value every time the user selects "Search".

So I pass the patch to "Failed QA" status.

Arg, stupid mistake, sorry. - [% IF av.authorised_value == additional_field_filters.${field.name} %] + [% IF av.authorised_value == additional_field_filters.${field.name}.value %] This should be fixed now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #105 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24453&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #107 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24455&action=edit Bug 10855: FIX bad conflict merge -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #109 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24457&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #112 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24570&action=edit Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11844 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #115 from Koha Team AMU <koha.aixmarseille@gmail.com> --- Caution : 10855 et 7677 should be compatible http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #117 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10855: <h1>Something went wrong !</h1>Applying: Bug 10855: Add the new package Koha::AdditionalField Applying: Bug 10855: Add unit tests for the new package Koha::AdditionalField Applying: Bug 10855: interface configuration for adding new fields to subscriptions Applying: Bug 10855: New fields on adding/updating a subscription Applying: Bug 10855: Search subscriptions by additional fields Applying: Bug 10855: Search subscriptions by additional fields on the claim page fatal: sha1 information is lacking or useless (C4/Serials.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10855: Search subscriptions by additional fields on the claim page When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10855 - Additional fields for subscriptions 23594 - Bug 10855: Add the new package Koha::AdditionalField 23595 - Bug 10855: Add unit tests for the new package Koha::AdditionalField 23596 - Bug 10855: interface configuration for adding new fields to subscriptions 23597 - Bug 10855: New fields on adding/updating a subscription 23598 - Bug 10855: Search subscriptions by additional fields 24452 - Bug 10855: Search subscriptions by additional fields on the claim page 24453 - Bug 10855: Squash several fixes 24454 - Bug 10855: Fix QA issues 24455 - Bug 10855: FIX bad conflict merge 24456 - Bug 10855: search with exact match if linked to an AV 24569 - Bug 10855: Update database entry 24570 - Bug 10855: Additional marc fields are not inserted Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10855-Search-subscriptions-by-additional-field-VvngGr.patch . -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24452|0 |1 is obsolete| | --- Comment #118 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26091&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24454|0 |1 is obsolete| | --- Comment #120 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26093&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24456|0 |1 is obsolete| | --- Comment #122 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26095&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24570|0 |1 is obsolete| | --- Comment #124 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26097&action=edit Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11302 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26092|0 |1 is obsolete| | --- Comment #127 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26255&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26094|0 |1 is obsolete| | --- Comment #129 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26257&action=edit Bug 10855: FIX bad conflict merge -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26096|0 |1 is obsolete| | --- Comment #131 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26259&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #135 from Zeno Tajoli <z.tajoli@cineca.it> --- Testing on MARC21 the two problems reported in comment 125 are still present. When I edit or create subscription : 1)Wrong display of diacritics in Additional field done with authorised value drop down menu (exemple : indéterminé = pb with é display) 2)I can't write in the box of an Additional field connect with MARC tag With prove t/db_dependent/AdditionalField.t all test are correct. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #137 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #136)

...

1)Wrong display of diacritics in Additional field done with authorised value drop down menu (exemple : indéterminé = pb with é display)

Could be fix with bug 11302.

Unfortunately, current iteration of 11302 patch seems to have some nasty, unexpected side effects in cases when there are uft-8 characters in additional field names (see bug 11302 comment #9). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #139 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #138)

Bug 10855: FIX encoding issues.

1) still needs ca 100 '| html_entity' to be added in various templates (just kidding, only 10 or so ;) 2) it's not plack compatible ("Variable "$additional_fields" will not stay shared at /home/koha/devkohaclone/serials/subscription-add.pl line 439") - I guess it's just a typo in: sub insert_additional_fields { my ( $additional_fiels, $biblionumber, $subscriptionid ) = @_; -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #141 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jacek Ablewicz from comment #139)

1) still needs ca 100 '| html_entity' to be added in various templates (just kidding, only 10 or so ;)

I would prefer another solution too.

2) it's not plack compatible ("Variable "$additional_fields" will not stay shared at /home/koha/devkohaclone/serials/subscription-add.pl line 439") - I guess it's just a typo in:

sub insert_additional_fields { my ( $additional_fiels, $biblionumber, $subscriptionid ) = @_;

Thanks for the catch! Sorry for that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23594|0 |1 is obsolete| | --- Comment #142 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28929&action=edit Bug 10855: Add the new package Koha::AdditionalField -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23596|0 |1 is obsolete| | --- Comment #144 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28931&action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23598|0 |1 is obsolete| | --- Comment #146 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28933&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26255|0 |1 is obsolete| | --- Comment #148 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28935&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26257|0 |1 is obsolete| | --- Comment #150 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28937&action=edit Bug 10855: FIX bad conflict merge -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26276|0 |1 is obsolete| | --- Comment #152 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28939&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26655|0 |1 is obsolete| | --- Comment #154 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28941&action=edit Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11944 | --- Comment #156 from Jonathan Druart <jonathan.druart@biblibre.com> --- I remove the dependency on bug 11944. The patches have not been developed on top of patches from bug 11944. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #158 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- It's a pity that this problem blocks this patch ! This functionnality is usefull ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #159 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29095&action=edit Bug 10855: FIX bad merge conflicts This patch fixes a bad merge conflicts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #161 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #160)

(In reply to Paola Rossi from comment #157)

...

in the table results, at the bottom of all the columns, the various filters "Search ...." were not OK:

Fixed with last patch.

Thanks, Jonathan. The problem was fixed in the table results of the open subscriptions, but not in the table results of the closed ones, same page. So I've passed again the patch to "Failed QA" status. NB. In the Update database entry patch (the 10-th), DBversion = "3.15.00.XXX" should be updated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29095|0 |1 is obsolete| | --- Comment #162 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29161&action=edit Bug 10855: FIX bad merge conflicts This patch fixes a bad merge conflicts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #164 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Jonathan. Now the problem in comment 161 is OK. I've applied against master 3.17.00.008 A) In the result table of closed subscriptions, on advanced search, the category additional fields are not shown. B) In the advanced search, in the result table of open SS, the name "Routing list" is posed on the wrong column, at the left of the column about routing lists. C) updatedatabase needs to be updated from DBversion 3.15.00.XXX. So I've passed the patch to "Failed QA" status. Note-1. If the additional fields are a lot, the table is very large. Some columns, such as ISSN, don't need so much width. Perhaps the functions (reopen, new, serial receive, issue history, ...) would be better seen at the left part of the rows. Note-2 Multiple occurrences of a MARC subfield: The patch filles Additional MARC fields with 1 subfield only 2-1: on repeatable MARC fields: I've create a subscription about a biblio whose 650 is triple; 650$v is present in all the three occurrences of 650. I've added an additional MARC field linked to 650$v. The field of the subscription is only filled with one occurrence of the 3 650$v subfields. 2.2: on repeated subfields in a MARC field: I've create a subscription about a biblio with one 650 and two 650$x in it. I've added an additional MARC field linked to 650$x. The field of the subscription is only filled with the first occurrence of the 2 650$x subfields. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED Depends on| |11944 --- Comment #166 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hello Paola, Thanks for testing and for your patience, but I don't manage to retest this development every time I rebase it. I would prefer to see bug 11944 pushed before continuing here. I mark this enh blocked by 11944. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13239 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #168 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35212&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #170 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35214&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #172 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35216&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #174 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35218&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #176 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35220&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #178 from Jonathan Druart <jonathan.druart@biblibre.com> --- Back to needs signoff for even more fun :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #180 from Paola Rossi <paola.rossi@cineca.it> --- I add to my last comment (179): NB. about the 9-th patch, the updated database has no "COLLATE". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #183 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Jonathan. I've applied the 12 patches against master 3.19.00.006 head 12889. In Comment 168:

Test plan: - prove t/db_dependent/AdditionalField.t

OK! In Comment 169:

Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields

I've added a new field with no "Authorised value category" and no MARC field [either searchable or not-searchable]. I think this is an error. For now I pass the patch to "Failed QA". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #185 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #184)

(In reply to Paola Rossi from comment #183)

...

I've added a new field with no "Authorised value category" and no MARC field [either searchable or not-searchable].

I think this is an error.

No, it is just a free text.

Thanks, Jonathan. So I turn back to "Needs Signed Off". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #188 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #186)

In the "Close (X)" tag the MARC additional fields of the subscriptions were displayed (RIGHT) whilst the category additional fields were not displayed (I think it was an ERROR).

Good catch! This is fixed with the last patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #189 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Jonathan. I've applied the [13] patches against master 3.19.00.006 head 13526 (!). As required in comment 172 [but I think that this step could also be added to the test plan in comment 171] - try filters on columns. a particular problem arose on FILTERING. See below. Moreover, being this patch closely related to authorized values and categories, I was in doubt about the displaying of the branch-limited additional values, as it is described by 3.18 manual. I've provided a possible "solution". Please see all in the NB.1 below. I think that on FILTERING there can be an error. For now I pass the patch in the "Failed QA" status. If FILTERING is not an error, and displaying AV is not a problem, and no other follow up is needed, I can sign off this patch attaching the 13 patches as usual. ---- FILTERING RIGHT: Some subscriptions had "periodicals" in a field of theirs. I've selected all of them in some way. Filtering by "perioa" at once no subscription was expected to be selected. It happened in 1 second (RIGHT) [subscriptions disappeared] I cancelled all the filter value: all those subscriptions were expected to be selected. It happened in 1 second (RIGHT) [subscriptions appeared again] [Now there was no filter value] Filtering by "perioà" at once [CTRL v] no subscription were expected to selected. It happened in 1 second (RIGHT). RIGHT "Incremental" filtering: Filtering by "perio" at once all those subscriptions were expected to be selected. It happened (RIGHT): nothing changed in the table. I added "a" at the right of the value, so I was "incrementally" filtering by "perioa". No subscription were expected to selected. It happened in 1 second (RIGHT). ERROR: "Incremental" filtering by adding diacritics exited in ERROR: Some subscriptions had "periodicals" in a field of theirs. I've selected all of them in some way. Filtering by "perio" all subscriptions were filtered (OK, like above RIGHT). I added "à" at the right of the value, so I was "incrementally" filtering by "perioà". No limitation happened in the resulting table in 30 seconds (ERROR). After 30 sec, I added "ò" at the right of the value, so I was "incrementally" filtering by "perioàò". No limitation happened in the resulting table in 30 seconds (ERROR). This error didn't happened adding "incrementally" to "perio": a Japanese (会) char, a number, a Greek (γ) char. This error occurred either on searching subscriptions' table or on serials claims' one. ---- FILTERING's ERROR END NB1. A special case of authorized values is about categories with branches-limited AV. See: <http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues> At point 232, [3.18] manual says about their setting: "If you would like to limit this authorized value category to only specific libraries you can choose them from the 'Branches limitation' menu. To have it show for all libraries just choose 'All branches' at the top of the list." This patch's behaviour about the branches-limited AVs was OK (RIGHT). At my tests, patch is OK [=as plan require] on a category whose AVs are all branch-limited, and also on a category whose AVs are a mixture of limited and not-limited. As desired and required by this patch's test plans: branches-limited AV are displayed on viewing a subscription, (subscription-detail.pl) (B) categories names [not the limited AVs' drop down list, like manual says] are shown on editing a subscription (subscription-add.pl) branches-limited AV are all displayed in the resulting tables, branches-limited AV are all "filter-able" in the resulting tables, (A) categories names [not the limited AVs' drop down list, like manual says] are shown among search fields on the left on searching subscriptions. IMO these branches-limited AV could also be displayed in the (A) drop down list (A), to be available to the selecting user. Assigning an attribute is not modifying/adding a value to a category. So IMO the (B) drop down list could also be shown. In simple terms the limit in 3.18 manual would be updated from: "To have it show" to: "A branch-limited AV is always shown to all libraries. To have it added and modified" Otherwise, if the current manual prevales, the part of this patch requiring to "show" AdVs could need to be reviewed. [Or Additional Values are not exactly a kind of Authorized Values.] Anyway, now this sentence of the manual: "If you would like to limit this authorized value category to only specific libraries you can choose them from the 'Branches limitation' menu." appears a little generic to me, not enough to let understand the "limit". The sentence could also be changed into: "If you would like to limit this authorized value to only specific libraries [...]" because each AuV can be "limited". NB2. This patch is closely related to authorized values&categories [adding/modifying]. http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues point 232: "Limit your Category to 10 characters (something short to make it clear what the category is for)" The user of this enhancement 10855 would probably be interested in using more than 10 chars. This manual's warning limit might be increased. ------------------------------------------------ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #191 from Jonathan Druart <jonathan.druart@biblibre.com> --- It would be great if you managed to reproduce the filtering issue on a sandbox (and tell me which one you have used) or took a screenshot before and after you filled the filter with the diacritic character. -- You are receiving this mail because: You are watching all bug changes.