[Bug 10704] New: Search term highlighting doesn't work beyond the first results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Bug ID: 10704 Summary: Search term highlighting doesn't work beyond the first results page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Reporting this bug on behalf of a customer. When 'OpacHighlightedWords' is set to 'Highlight' in the system preferences only the first page of search results appear to be highlighted. Any following results pages do not obey this preference. To test; 1. Enable the above preference 2. Run a search that is known to get at least two pages wroth of results in the OPAC 3. Verify that on page one of the results, the terms you searched for are all highlighted in the results. 4. Verify that on page two (and beyond), the terms you searched for are not highlighted in the results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6149 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com --- Comment #1 from Jonathan Field <jonathan.field@ptfs-europe.com> --- To be clear, it is the paging with the "Next" / "Previous" buttons which are affected. So :- Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail). 4) Moving forward or back, the highlighting disappears. Moving from results to the first full record the URL contains the query_desc param from the session data. This is dropped as you navigate back and forth, leaving only the biblionumber. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 --- Comment #2 from Jonathan Field <jonathan.field@ptfs-europe.com> --- Created attachment 20216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20216&action=edit fix for search term highlighting on record navigation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Jonathan Field <jonathan.field@ptfs-europe.com> --- To test Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title of one of the results to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail) to move to the next or previous record. 4) Moving forward or back, the highlighting should still be working on the page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20216|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20218&action=edit Hit highlighting not working on Previous & Next buttons http://bugs.koha-community.org/show_bug.cgi?id=10704 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Simple patch. Fix the described issue. I will c/p the test plan on my SO patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20218|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20459&action=edit Bug 10704: Hit highlighting not working on Previous & Next buttons To test Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title of one of the results to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail) to move to the next or previous record. 4) Moving forward or back, the highlighting should still be working on the page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10704 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #10 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.20. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org