https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 146941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146941&action=edit Bug 33009: bump Standards-Version to 4.6.2 to test: - build package on debian-unstable, note failure - apply patch - build package on debian-unstable, note success -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Not really tested this, but I trust Mason to do the right thing and fix if it was wrong. Please reset to NSO if you disagree. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Magnus Enger from comment #4)

Not really tested this, but I trust Mason to do the right thing and fix if it was wrong. Please reset to NSO if you disagree. :-)

I understand. But a signoff or QA should be passed on something, right? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- If I understand correctly this is just bumping the version while the package isn't in accordance to the standards. We might be okay with this if the changes needed are tedious without much value. Since it's not about having an official Koha package in Debian's repo. But what would be the needed changes? To actually choose what to pick or not. To not miss on something important that might cause issues in the future. I never did Debian packaging so maybe it's totally irrelevant, you tell us Mason. By any chance, does a compliance tool exists so the assessment itself isn't a big task? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #6)

I am reading: When updating existing packaging, the Standards-Version must not be updated except after reviewing the changes between the old and the new versions of the standards and updating your package if necessary (the Upgrading checklist can help with this task).

Mason, how do/did we implement that review ?

I think this is the checklist to which Marcel was referring: https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt There's about 4,884 words spanning 12 years in-between 3.8.4 and 4.6.2 so I don't think anyone's fully reviewed it. Perhaps we don't need to update all the way to 4.6.2 though. Maybe it's worth finding a middle ground and doing a review between 3.8.4 and there. I spent a little bit of time checking backwards from 3.8.4 and we looked compliant before it, although it's possible that we might not be 100% compliant going back to the very beginning... -- You are receiving this mail because: You are watching all bug changes.