http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 10864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10864&action=edit Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen This patch fixes the bug preventing the prompts to retain or transfer holds to the next person in the holds queue. Wording and styling improvements will follow in Bug 8449. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #3)

How I tested:

- Item X is checked out.

- Place holds for patron ONE and patron TWO (Next available item, there ist just 1 item for this biblio anyway)

- Check in Itm X. Koha says that there is a hold for Patron ONE (General note, not related to this patch: I would expect that it says soething about patron TWO as well or something like 'There are N holds for this item').

- I confirm hold for patron ONE

- I switch to Holds Awaiting Pickup in the Circulation module

- I see the hold waiting for Patron ONE

- I cancel this hold.

- I get following message (as expected after applying the patch): ------------------- This hold (Fuss- und Wanderwege bei der Planung von ländlichen Wegnetzen im Berggebiet) was placed by : Patron TWO, Please retain this hold. [Daten absenden] (a button, it seems to take the OS language) ------------------

- Now I'm not quite sure what 'Daten absenden' really means? - It seems to delete the hold for patron ONE (what actually I expect), but then, I would expect the item now to appear in the pickup list as waiting for pickup by patron TWO?

- But now the list is empty. What happens now to the hold placed by patron TWO? Is there some action I have to take now manually?

When I translated "Daten absenden" to English, it said "Data send", so it's the equivalent of "Submit". I think "OK" would be better than "Submit", but that's outside of the scope of this particular patch. Yes, now that the list is empty, you have to manually check-in the item again to generate the prompt to "confirm hold" for Patron TWO. This is the default Koha behaviour. In Bug 8449, I change the wording and styling of the messages you receive during this process, and I've indicated that you need to check-in the item to continue processing the hold. Sounds like it worked though :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 11045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11045&action=edit [SIGNED-OFF] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt When you cancel a hold in the "Hold Waiting" tab of Holds Awaiting Pickup, you should be prompted to retain or transfer the hold for the next patron in the queue. However, instead of seeing this prompt, you are just shown white screen that fails to alert you to the fact that there are more holds on that item! There is a missing FOREACH reference in waitingreserves.tt. The template tries to directly reference the hash within the cancel_results array, but we need to access the array before we can access the hash. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 --- Comment #7 from Marc Véron <veron@veron.ch> --- Always got Traceback error during git bz attach -e (due to slow internet connection). Anyway, patch behaves as expected, signed off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11045|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11080&action=edit [SIGNED-OFF] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt Since Bug 6039, cancel_result is an arrayref. It is logical to do a FOREACH on it. Marking as Passed QA. This new patch replaces tab characters with 4 spaces, please update your editor configuration. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8448 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: valid_tt.t still OK after this patch -- You are receiving this mail because: You are watching all bug changes.