[Bug 26211] New: Patron age checking while doing the membership registration through OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Bug ID: 26211 Summary: Patron age checking while doing the membership registration through OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org Currently we are not checking patron age while doing the membership registration from the OPAC. We are checking patron age while doing registration through Staff page. for ex: "The following fields are wrong. Please fix them. Patron's age is incorrect for their category. Ages allowed are 5-17." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |amitddng135@gmail.com CC| |amit.gupta@informaticsgloba | |l.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #1 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108283&action=edit Bug 26211-Patron age checking while doing the membership registration through OPAC To Test 1. Create the patron category from the staff page for ex: Kid and give age required and age Upperage limit age required 5 yrs and upperage limit 17. 2. Allow category in PatronSelfRegistrationDefaultCategory for online registration from opac. 3. Go to /cgi-bin/koha/opac-memberentry.pl page. 4. Fill the form and give choose date of birth 10/10/1974 and click OK. Now you can able to save the page. 5. Apply the patch. 6. Again go to cgi-bin/koha/opac-memberentry.pl page. 7. Fill the form and give choose date of birth 10/10/1974 and click OK. It will give the error message. Patron's age is incorrect for their category. Ages allowed are 5-17. ------------------------------------------------------------------------ This patch check patron age defined in the patron categories while doing the registration from the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looks good on first glance! Commit message needs a little fix - Bug 26211: Patron ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron age checking while |Patron age verification |doing the membership |while doing the |registration through OPAC |self-registration --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Katrin Fischer from comment #2)
Looks good on first glance! Commit message needs a little fix - Bug 26211: Patron ...
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #4 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Katrin Fischer from comment #2)
Looks good on first glance! Commit message needs a little fix - Bug 26211: Patron ...
I think below message looks OK. "Patron age verification while doing the self-registration" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108283|0 |1 is obsolete| | --- Comment #5 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108303&action=edit Bug 26211 - Patron age verification while doing the self-registration. Modify Commit message -> "Patron age versification while doing the self-registration" To Test 1. Create the patron category from the staff page for ex: Kid and give age required and age Upperage limit age required 5 yrs and upperage limit 17. 2. Allow category in PatronSelfRegistrationDefaultCategory for online registration from opac. 3. Go to /cgi-bin/koha/opac-memberentry.pl page. 4. Fill the form and give choose date of birth 10/10/1974 and click OK. Now you can able to save the page. 5. Apply the patch. 6. Again go to cgi-bin/koha/opac-memberentry.pl page. 7. Fill the form and give choose date of birth 10/10/1974 and click OK. It will give the error message. Patron's age is incorrect for their category. Ages allowed are 5-17. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The QA scripts complain if the commit message doesn't start with Bug xxxx: - that was what I meant, but I was not clear about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I'm getting some errors from this. If I have the patron category field exposed in the patron self-registration form I get this error when submitting the form with an invalid date of birth: Can't call method "param" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 485 If I hide the patron category field and submit the form with a valid or invalid date of birth I get this error: Can't call method "dateofbirthrequired" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 482 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #8 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Owen Leonard from comment #7)
I'm getting some errors from this. If I have the patron category field exposed in the patron self-registration form I get this error when submitting the form with an invalid date of birth:
Can't call method "param" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 485
If I hide the patron category field and submit the form with a valid or invalid date of birth I get this error:
Can't call method "dateofbirthrequired" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 482
Thank Owen for giving the feedback. I am able to reproduce the second issue. But with first one I am able to save the form and not find any issue. In case if I am giving the invalid date of birth (In reply to Owen Leonard from comment #7)
I'm getting some errors from this. If I have the patron category field exposed in the patron self-registration form I get this error when submitting the form with an invalid date of birth:
Can't call method "param" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 485
If I hide the patron category field and submit the form with a valid or invalid date of birth I get this error:
Can't call method "dateofbirthrequired" on an undefined value at /kohadevbox/koha/opac/opac-memberentry.pl line 482
Thank Owen for giving the feedback. I am able to reproduce the second issue. But with first one I am able to save the form and not find any issue. In case if I am giving the invalid date of birth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #9 from Amit Gupta <amitddng135@gmail.com> --- I have checked and calendar have some issues. While doing the registration from OPAC if we will give any invalid date it is not giving any alert or error message. It's simply saving the record. I will raise a bug to fix the calendar issue on the OPAC side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26218 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Erica Rohlfs <erica.rohlfs@equinoxOLI.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21602 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@biblibre.co | |m --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 21602 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Will this get worked on again? Seems like we could easily use is_age_valid here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I don't think we should pass along any information about the age requirements for a given patron category. (Ages allowed are [% age_low | html %]-[% age_high | html %].) It's not a hint to allow the user to adjust their DOB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175366&action=edit Bug 26211: (follow-up) Remove age_low and age_high template variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|amitddng135@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175366|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 175582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175582&action=edit Bug 26211: (follow-up) Remove age_low and age_high template variables Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam.sowanick@corvallisorego | |n.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have removed the "Please try again." as we also show "Please correct and resubmit" below the errors and it seemed like a bit of a double up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patron age check is also done when an existing patron updates their address etc. information. You can still leave it empty, if it's not made mandatory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds age release notes| |verification checking to | |the self-registration and | |personal details forms. A | |message is now shown if the | |date of birth entered | |doesn't match with the | |patron category age range, | |"Patron's age is incorrect | |for their category. Please | |try again.". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26211 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #19 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org