[Bug 38240] New: Filtering resulting in no result will hide filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Bug ID: 38240 Summary: Filtering resulting in no result will hide filters Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 38118 If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 [Bug 38118] Removed empty columns on holdings table on details page are not restored when new items loaded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173217&action=edit Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Remember user's table state for all tables (Generalise table saveState for all tables) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173217|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173223&action=edit Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #1)
Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again.
Are you able to provide instructions to reproduce this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173223|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173246&action=edit Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Not quite as dire as "impossible to modify" - just click Hide filters and then Show filters. Certainly "annoying to modify" though, especially if you've already set several other filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #3)
(In reply to Jonathan Druart from comment #1)
Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again.
Are you able to provide instructions to reproduce this?
No, actually that didn't make sense. If you select a value there will be data. I was typing the commit message with what came to mind it seems... I will remove this part from the commit message. (In reply to Phil Ringnalda from comment #5)
Not quite as dire as "impossible to modify" - just click Hide filters and then Show filters. Certainly "annoying to modify" though, especially if you've already set several other filters.
Yes ofc, but then you are loosing the state of the table. Thanks you both for the signoff! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173246|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173253&action=edit Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Converting this to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38118 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org