[Bug 7328] New: Expanded options in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Bug #: 7328 Summary: Expanded options in advanced search Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: frederic@tamil.fr QAContact: ian.walls@bywatersolutions.com In OPAC and intra advanced search, more search options are displayed depending on expandedSearchOption syspres and user choice. This doesn't work anymore in HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-12-07 08:11:20 UTC --- Created attachment 6633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6633 Proposed patch In OPAC and intra advanced search, more search options are displayed depending on expandedSearchOption syspref and user choice. This doesn't work anymore in HEAD. This patch restore this functionality. To test: - enable/disable expandedSearchOption. - Load advanced search page. Limited seach options version is always displayed - Apply this patch and see how it works... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6633|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-08 06:36:28 UTC --- Created attachment 6660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6660 [SIGNED-OFF] Bug 7328 Expanded options in advanced search In OPAC and intra advanced search, more search options are displayed depending on expandedSearchOption syspres and user choice. This doesn't work anymore in HEAD. This patch restore this functionnality. To test: - enable/disable expandedSearchOption. - Load advanced search page. Limited seach options version is always displayed - Apply this patch and see how it works... Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The problem only appeared in the staff client for me. Tested both OPAC and staff with patch applied. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off Severity|minor |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 16:22:16 UTC --- QA comment : I can't see any difference with and without the patch. Frédéric, looking at your code, it seems it does something only if the syspref is not defined, which should not happend. Marking failed QA until I have more information about how to reproduce the problem -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2011-12-15 16:44:15 UTC ---
QA comment :
Thanks for going through this patch.
I can't see any difference with and without the patch. Frédéric, looking at your code, it seems it does something only if the syspref is not defined, which should not happend.
I don't think so. Expanded search option are passed with a CGI param, it is used (and controlled), otherwise syspref is used.
Marking failed QA until I have more information about how to reproduce the problem
1. On HEAD, in intra interface, enable expandedSearchOption syspref 2. Click Search link in the top links bar. 3. Next to Search button, you can see [More options] link. This is wrong. We should have [Fewer options] 4. Commit the patch 5. Repeat 1-2 6. Next to Search button, you have [Fewer options] link. This is correct. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 09:06:25 UTC --- Hi Paul, for me the problem only occured in the staff interface, not int he OPAC. Perhaps this helps. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Failed QA |Patch Pushed --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-30 11:07:41 UTC --- QA comment: thanks for the explanation Frédéric, it worked now. I suspect I made something wrong in my 1st tests, because I hadn't this behaviour. perlcritic catalogue/search.pl catalogue/search.pl source OK passed QA patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7328 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org