https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43793 Bug ID: 43793 Summary: 26.05.04 backport of bug 42605 is incomplete Initiative type: --- Sponsorship --- status: Product: Koha Version: 26.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mark@hofstetter.at QA Contact: testopia@bugs.koha-community.org Target Milestone: --- This is a follow-up to bug 42605: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605 The fix released in Koha 26.05.04 only corrects AcqCreateItem. UniqueItemFields is still converted to the numeric value 0/1, so the acquisition receiving dialog remains broken when items are created on receipt. Tested package ============== koha-common 26.05.04-1 Steps to reproduce ================== 1. Set AcqCreateItem to "receiving an order". 2. Set UniqueItemFields to a non-empty value, for example "barcode|stocknumber". 3. Create an order and open it for receipt. 4. Observe that the receiving dialog remains on its loading indicator and the item-entry form is not displayed. Actual result ============= The English template shipped with 26.05.04 contains: Koha.addPrefs({ AcqCreateItem: "[% Koha.Preference('AcqCreateItem') | html %]", UniqueItemFields: [% Koha.Preference('UniqueItemFields') ? 1 : 0 | html %], }); JavaScript therefore receives the number 1 and additem.js fails when it calls: unique_item_fields.split("|") Expected result =============== Both preferences must remain strings: Koha.addPrefs({ AcqCreateItem: "[% Koha.Preference('AcqCreateItem') | html %]", UniqueItemFields: "[% Koha.Preference('UniqueItemFields') || '' | html %]", }); Cause ===== On main, commit 35b58d65c5 from bug 43211 had already corrected UniqueItemFields before bug 42605 commit 757b347bed was applied. The latter therefore only changes AcqCreateItem in its final diff. The 26.05.04 backport appears to include 757b347bed without the relevant change from 35b58d65c5. This makes the stable backport incomplete even though bug 42605 is listed as fixed in 26.05.04. The same incorrect expression is present in the packaged English and de-DE templates. Applying the expected line locally and restarting Plack restores the item-entry form. Please backport the missing UniqueItemFields change to 26.05.x and include it in the next maintenance release. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.