[Bug 13253] New: Unnecessary white space above checkouts table in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Bug ID: 13253 Summary: Unnecessary white space above checkouts table in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 11703 The DataTables sDom configuration for the new AJAX circulation checkouts table contains some superfluous markup which pushes the checkouts table down. This distance can mean the difference, on some screens, between being able to see the last item checked out or not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33543&action=edit Bug 13253 - Unnecessary white space above checkouts table in circulation On the new checkouts page there is some padding above the checkouts, relatives' checkouts, and holds tables caused by extra markup in the table's sDom configuration (http://legacy.datatables.net/ref#sDom): <'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t This creates several empty <div>s which don't serve any purpose. This patch simplifies it to: rt To test, apply the patch, clear your browser cache, and check out to a patron who has items checked out, holds on their account, and child records attached which also have checkouts. The padding above the table of checkouts, the table of relatives' checkouts, and the table of holds should match that on the sides. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33543|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 33544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33544&action=edit Bug 13253 - Unnecessary white space above checkouts table in circulation On the new checkouts page there is some padding above the checkouts, relatives' checkouts, and holds tables caused by extra markup in the table's sDom configuration (http://legacy.datatables.net/ref#sDom): <'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t This creates several empty <div>s which don't serve any purpose. This patch simplifies it to: rt To test, apply the patch, clear your browser cache, and check out to a patron who has items checked out, holds on their account, and child records attached which also have checkouts. The padding above the table of checkouts, the table of relatives' checkouts, and the table of holds should match that on the sides. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Checked per plan on both Check Out and Details pages, spacing appears correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33544|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33545&action=edit [PASSED QA] Bug 13253 - Unnecessary white space above checkouts table in circulation On the new checkouts page there is some padding above the checkouts, relatives' checkouts, and holds tables caused by extra markup in the table's sDom configuration (http://legacy.datatables.net/ref#sDom): <'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t This creates several empty <div>s which don't serve any purpose. This patch simplifies it to: rt To test, apply the patch, clear your browser cache, and check out to a patron who has items checked out, holds on their account, and child records attached which also have checkouts. The padding above the table of checkouts, the table of relatives' checkouts, and the table of holds should match that on the sides. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Checked per plan on both Check Out and Details pages, spacing appears correct. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org