[Bug 27562] New: itiva notices break if record title contains quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Bug ID: 27562 Summary: itiva notices break if record title contains quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115909&action=edit Bug 27562: itiva notices break if record title contains quotes itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). Test Plan: 1) Set up itiva to send phone notes 2) Find a record with quotes in the title 3) Trigger an itiva notice ( checkout, checkin, place hold, etc ) using the itiva outbound cronjob 4) View the CSV, note the title has the quotes in it 5) Apply this patch 6) Repeat steps 2-3 7) View the CSV, note the title contains no quotes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115909|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 120351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120351&action=edit Bug 27562: itiva notices break if record title contains quotes itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). Test Plan: 1) Set up itiva to send phone notes 2) Find a record with quotes in the title 3) Trigger an itiva notice ( checkout, checkin, place hold, etc ) using the itiva outbound cronjob 4) View the CSV, note the title has the quotes in it 5) Apply this patch 6) Repeat steps 2-3 7) View the CSV, note the title contains no quotes! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- works :) git author needs a fix: * Author 'Koha user' seems invalid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120351|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120688&action=edit Bug 27562: itiva notices break if record title contains quotes itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). Test Plan: 1) Set up itiva to send phone notes 2) Find a record with quotes in the title 3) Trigger an itiva notice ( checkout, checkin, place hold, etc ) using the itiva outbound cronjob 4) View the CSV, note the title has the quotes in it 5) Apply this patch 6) Repeat steps 2-3 7) View the CSV, note the title contains no quotes! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Victor Grousset/tuxayo from comment #3)
git author needs a fix:
I have taken the liberty of correcting it for Kyle so that it can go into the QA queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Owen :) QA: Looks good to me. I'll try to find someone to signoff. Test note: here are instruction to setup i-tiva https://wiki.koha-community.org/wiki/External_Integration#i-tiva -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120688|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120802&action=edit Bug 27562: itiva notices break if record title contains quotes itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). Test Plan: 1) Set up itiva to send phone notes 2) Find a record with quotes in the title 3) Trigger an itiva notice ( checkout, checkin, place hold, etc ) using the itiva outbound cronjob 4) View the CSV, note the title has the quotes in it 5) Apply this patch 6) Repeat steps 2-3 7) View the CSV, note the title contains no quotes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Owen :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org