[Bug 29952] New: Filter Paid Transactions Broken on Transactions tab in Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Bug ID: 29952 Summary: Filter Paid Transactions Broken on Transactions tab in Staff Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisetteslatah@gmail.com QA Contact: testopia@bugs.koha-community.org I tested in both master and on 21.05.08 and the "Filter paid transactions" link on members/boraccount.pl does nothing anymore. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's also broken on 20.11 - thx for the bug Lisette, it kept escaping from my list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129873&action=edit Bug 29952: [20.11.x] Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129874&action=edit Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Lisette Scheer <lisetteslatah@gmail.com> --- The table no longer appears to be a datatable, just a regular table. The console gives me the following error: boraccount.pl:1596 Uncaught SyntaxError: Unexpected token '<<' This is line 1596 in the source code: <<<<<<< HEAD Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lisette Scheer from comment #4)
This is line 1596 in the source code: <<<<<<< HEAD
This bug report has two patches, one for master and one for 20.11.x. Applying both will cause a conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129873|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130041&action=edit Bug 29952: [20.11.x] Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested the 20.11 patch and it works like a charm, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129874|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 130160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130160&action=edit Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Tested and signed off the patch for master (20.11 patch already tested by Katrin). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130160|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130333&action=edit Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Filter paid release notes| |transactions" link in the | |staff interface on the | |Patron account > Accounting | |> Transactions tab. It now | |correctly filters the list | |of transactions - only | |transactions with an | |outstanding amount greater | |than zero are shown ("Show | |all transactions" clears | |the filter). Before this | |fix, clicking on the link | |didn't do anything and | |didn't filter any of the | |transactions as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #14)
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.
It is actually, but maybe a little late now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I should still be able to backport and push to the branch. Does that help? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sure :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Sorry, I don't have the rights for the branch anymore. I just applied the 20.11.x patch locally but couldn't test it because something is wrong with my local koha environment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #18)
Sorry, I don't have the rights for the branch anymore. I just applied the 20.11.x patch locally but couldn't test it because something is wrong with my local koha environment.
Sorry, that's on me. I was looking at the 22.05 roles page... not realizing that 20.11 is already EOL. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org