[Bug 17194] New: When edit record, Button "Z39.50/SRU search" not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Bug ID: 17194 Summary: When edit record, Button "Z39.50/SRU search" not work Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: dudzikmichal@wp.pl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When edit record and click to button "Z39.50/SRU search" the popup not showing. Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15859 CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, could you have a look at this one? It has been introduced by bug 15859, the #Frameworks select is now removed and a JS error is raised: TypeError: document.forms.f.Frameworks is undefined var strQuery="&frameworkcode="+document.forms['f'].Frameworks.value; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 [Bug 15859] Move some basic MARC editor controls into settings menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17206 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55343&action=edit Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55343|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 55384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55384&action=edit Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Working again, great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55384|0 |1 is obsolete| | --- Comment #4 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 55439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55439&action=edit Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Working again, great! Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Patch works fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55439|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55461&action=edit [PASSED QA] Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Working again, great! Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Patch works fine. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17194 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org