[Bug 16300] New: Remove the use of "onclick" from circulation and fine rules template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Bug ID: 16300 Summary: Remove the use of "onclick" from circulation and fine rules template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/smart-rules.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org, veron@veron.ch Depends on: 15456 There is one place where an "onclick" attribute is used in admin/smart-rules.tt. It should be rewritten so that JS functionality is separate from the markup. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50435&action=edit Bug 16300 - Remove the use of "onclick" from circulation and fine rules template This patch updates the circulation and fine rules template so that the "clear" button does not require an "onclick" attribute. To test, apply the patch and go to Administration -> Circulation and fine rules. - Edit an existing rule. - Click the "Clear" button and confirm. The entry form should be reset to its blank state. - Click the "Clear" button and cancel. The entry form should remain the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50435|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 50453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50453&action=edit Bug 16300 - Remove the use of "onclick" from circulation and fine rules template This patch updates the circulation and fine rules template so that the "clear" button does not require an "onclick" attribute. To test, apply the patch and go to Administration -> Circulation and fine rules. - Edit an existing rule. - Click the "Clear" button and confirm. The entry form should be reset to its blank state. - Click the "Clear" button and cancel. The entry form should remain the same. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, looking at this, maybe it would make sense to redo the patch without the dependency on 15456. What do you think? Moving to PDA for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16300 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED CC| |hayleymapley@catalyst.net.n | |z --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- This look to have been remedied on master. Setting to Resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org