[Bug 29744] New: Harmonize psgi/plack detection methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Bug ID: 29744 Summary: Harmonize psgi/plack detection methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org In Bug 29420, C4::Context->is_psgi_or_plack() is introduced to check for psgi/plack environmental variables, since C4::Auth::psgi_env doesn't check for "plack" environmental variables which means psgi/plack detection fails. We should replace C4::Auth::psgi_env calls with C4::Context->is_psgi_or_plack() if possible. We should also use C4::Context->is_psgi_or_plack() instead of manually scanning the %ENV hash for psgi/plack variables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29420 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132299&action=edit Bug 29744: Harmonize psgi/plack detection methods This patch updates and moves the existing psgi_env method out of Auth and into Context and then replaces any manual references of the same code to use the new method. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 27555 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Bug 27555 comment 3 """ I don't understand why psgi_env and safe_exit were in the BEGIN block. Should we expect a regression from CAS or Shib auth here? """ Will see once it's pushed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132299|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132975&action=edit Bug 29744: Harmonize psgi/plack detection methods This patch updates and moves the existing psgi_env method out of Auth and into Context and then replaces any manual references of the same code to use the new method. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Passed QA |Failed QA --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- I cant get this working. With Bug 29420 and this one I get directly the error : psgi:exit at /kohadevbox/koha/C4/Auth.pm line 59 59: if (C4::Context::psgi_env) { die 'psgi:exit' } I tried to remove manually the session cookie but same problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #5)
I cant get this working. With Bug 29420 and this one I get directly the error :
psgi:exit at /kohadevbox/koha/C4/Auth.pm line 59 59: if (C4::Context::psgi_env) { die 'psgi:exit' }
I tried to remove manually the session cookie but same problem.
I just applied bug 29420 and bug 29744 to master, ran "koha-plack --restart kohadev", and navigated through both the OPAC and staff interface with no problems. However, when I logged out of the Staff Interface, I encountered the same problem as Fridolin (as the logout code calls C4::Auth's safe_exit function). I'll do a little bit of troubleshooting on this, but I think the answer is to not change the BEGIN block in this bug report, since it's really a secondary change that doesn't really relate to the majority of what this bug report is trying to accomplish... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 132975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132975 Bug 29744: Harmonize psgi/plack detection methods Review of attachment 132975: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29744&attachment=132975) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +56,3 @@
+sub safe_exit { + if (C4::Context::psgi_env) { die 'psgi:exit' }
Ok, so the problem here isn't the BEGIN block, but rather that the old psgi_env() checked only for "psgi." keys whereas the new C4::Context::psgi_env checks for "psgi." keys or "plack." keys. This is significant because CGI::Emulate::PSGI (which runs our CGI scripts as PSGI functions) removes all "psgi." keys from the environment: https://metacpan.org/dist/CGI-Emulate-PSGI/source/lib/CGI/Emulate/PSGI.pm#L5... That's why to detect Plack/PSGI in Koha we have to look for those "plack." variables like plack.file.SCRIPT_NAME and plack.file.PATH_INFO, which are added by Plack::App::File (via Plack::App::CGIBin. It's fine for us to "exit" because CGI::Compile (used in Plack::App::WrapCGI) redefines "exit" for us automatically. Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't actually need this PSGI detection at all here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't actually need this PSGI detection at all here.
Tracked the origin of this back to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630#c10 https://lists.koha-community.org/pipermail/koha-patches/2011-March/014376.ht... It looks like antique code that probably hasn't done anything useful for many years. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
It looks like antique code that probably hasn't done anything useful for many years.
This is made all the more obvious by the usage of "exit" all over our CGI code and our very slim usage of "safe_exit" (limited only to C4::Auth). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132975|0 |1 is obsolete| | --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 133429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133429&action=edit Bug 29744: Harmonize psgi/plack detection methods This patch updates and moves the existing psgi_env method out of Auth and into Context and then replaces any manual references of the same code to use the new method. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 133430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133430&action=edit Bug 29744: Remove unnecessary condition in C4::Auth::safe_exit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- I've signed off Martin's patch, added my own to fix the issue Frido found, and moved back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Bug 29744 depends on bug 29420, which changed state. Bug 29420 Summary: HTTP status code incorrect when calling error pages directly under Plack/PSGI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #7)
It's fine for us to "exit" because CGI::Compile (used in Plack::App::WrapCGI) redefines "exit" for us automatically.
Since we only seem to use C4::Auth::safe_exit in a CGI context, we don't actually need this PSGI detection at all here.
These comments should have been included in the commit message. I will adjust it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #12)
I've signed off Martin's patch, added my own to fix the issue Frido found, and moved back to Needs Signoff.
I will consider this patch as Signed off and QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Putting bug 31468 (from myself) in the picture here too: When running API, we need to look for $ENV{PLACK_ENV}, but the underscore is not included in the Context sub. sub is_psgi_or_plack { my $is_psgi_or_plack = 0; - if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) { + if ( any { /^(psgi|plack)[._]/i } keys %ENV ) { And note, with unit tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31468 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Also note that C4::Context routines should normally be OO (at least it was designed that way). Moving the test from 31468 here too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #16)
Also note that C4::Context routines should normally be OO (at least it was designed that way). Moving the test from 31468 here too
errors/400.pl:if ( C4::Context->is_internal_PSGI_request() ) { errors/401.pl:if ( C4::Context->is_internal_PSGI_request() ) { errors/402.pl:if ( C4::Context->is_internal_PSGI_request() ) { errors/403.pl:if ( C4::Context->is_internal_PSGI_request() ) { errors/404.pl:if ( C4::Context->is_internal_PSGI_request() ) { errors/500.pl:if ( C4::Context->is_internal_PSGI_request() ) { opac/errors/400.pl:if ( C4::Context->is_internal_PSGI_request() ) { opac/errors/401.pl:if ( C4::Context->is_internal_PSGI_request() ) { opac/errors/402.pl:if ( C4::Context->is_internal_PSGI_request() ) { opac/errors/403.pl:if ( C4::Context->is_internal_PSGI_request() ) { opac/errors/404.pl:if ( C4::Context->is_internal_PSGI_request() ) { opac/errors/500.pl:if ( C4::Context->is_internal_PSGI_request() ) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This might be slightly confusing, but not touching it here: Koha/App/Plugin/CGIBinKoha.pm:sub _psgi_env { Kind of name clash.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133429|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140689&action=edit Bug 29744: Harmonize psgi/plack detection methods This patch updates and moves the existing psgi_env method out of Auth and into Context and then replaces any manual references of the same code to use the new method. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133430|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140690&action=edit Bug 29744: Remove unnecessary condition in C4::Auth::safe_exit Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Adding David's comments from Bugzilla to safe_exit here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140691&action=edit Bug 29744: (QA follow-up) Add underscore test, move to OO The underscore test comes from bug 31468. Context methods should actually be OO. Test plan: Run t/Context.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140692&action=edit Bug 29744: (QA follow-up) Call psgi_env in OO style Result of git grep -l -E "::psgi_env" | xargs sed -i -e's/::psgi_env/->psgi_env/g' Also resolving this warn from Auth.t: Use of uninitialized value $ENV{"SCRIPT_NAME"} in pattern match (m//) at /usr/share/koha/Koha/AuthUtils.pm line 211. Note that the following warn is resolved on report 30588 (underway). Use of uninitialized value $return in numeric gt (>) at /usr/share/koha/C4/Auth.pm line 1154. Test plan: Run t/db_dependent/Auth.t Hit some opac, intranet pages. API call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 [Bug 31468] Koha::Logger should prefix interface with 'plack' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31468 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 140922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140922&action=edit Bug 29744: (QA follow-up) Only consider PLACK_ENV for underscore When run under certain circumstances (in jenkins, for example) some ENV variables are set for convenience, like PLACK_WORKERS and PLACK_MAX_REQUESTS and is causing some tests to fail (notably, shib ones). This patch makes the regex only consider PLACK_ENV when testing for the underscore case. Tests are updated accordingly, and they are also rewritten to test for boolean values instead of empty string, or zero or one, etc. The implementation shouldn't matter as long as the boolean evaluation is correct and it is clearer for devs what to expect. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #24)
Created attachment 140922 [details] [review] Bug 29744: (QA follow-up) Only consider PLACK_ENV for underscore
When run under certain circumstances (in jenkins, for example) some ENV variables are set for convenience, like PLACK_WORKERS and PLACK_MAX_REQUESTS and is causing some tests to fail (notably, shib ones).
This patch makes the regex only consider PLACK_ENV when testing for the underscore case.
Tests are updated accordingly, and they are also rewritten to test for boolean values instead of empty string, or zero or one, etc. The implementation shouldn't matter as long as the boolean evaluation is correct and it is clearer for devs what to expect.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Thx for following up. I will still have a look next week. This might break something else again? ;) As done in one of those tests, we may just need to localize $ENV in Shibboleth tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks fine to me, Tomas. I needed PLACK_ENV at least.. As a side note, it looks to me that t/Auth_with_shibboleth makes a few assumptions about its environment that could have been baken into the test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported for 22.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org