[Bug 10120] New: Fine recalculation on return needs to be a system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Bug ID: 10120 Summary: Fine recalculation on return needs to be a system preference Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de CC: chris@bigballofwax.co.nz, gmcharlt@gmail.com, kyle.m.hall@gmail.com As agreed on IRC today, recalculation of fines on return needs to be tied to a system preference as it changes the fines workflow. Ideally the system preference would have 3 settings: - recalculate always - recalculate only for hourly loans - don't recalculate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10119 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- There is currently no way to know something is an hourly loan or not. So the first implementation of this will only be on or off. If someone wants to change circulation to store if something was an hourly loan or not on the issue row then it could be expanded to 3 choices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17824&action=edit Bug 10120 : Adding a syspref to control if overdue charges are updated /on return On by default, To Test 1/ Create an overdue item, that should get fines 2/ Return the item 3/ Check the borrowers record to see if the fine has been added/updated Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 above 2/ Switch the preference to don't Repeat stes 1-2 3/ Check the fine hasn't been added/updated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17825&action=edit Bug 10120 : Tidy up the code so we can see what is going on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Only briefly tested, please test thoroughly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17824|0 |1 is obsolete| | --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 17885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17885&action=edit [Signed off] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return On by default, To Test 1/ Create an overdue item, that should get fines 2/ Return the item 3/ Check the borrowers record to see if the fine has been added/updated Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 above 2/ Switch the preference to don't Repeat stes 1-2 3/ Check the fine hasn't been added/updated Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17885|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 17886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17886&action=edit [Signed off] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return On by default, To Test 1/ Create an overdue item, that should get fines 2/ Return the item 3/ Check the borrowers record to see if the fine has been added/updated Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 above 2/ Switch the preference to don't Repeat stes 1-2 3/ Check the fine hasn't been added/updated Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17825|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 17887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17887&action=edit [Signed off] Bug 10120 : Tidy up the code so we can see what is going on Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook@prosentient.com.au --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Works as described. I doubt a library would want to have this system preference on for any case except hourly loans, but since there is no way to tell if a loan is hourly or not, this binary method is the best we've got. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17886|0 |1 is obsolete| | Attachment #17887|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18143&action=edit [PASSED QA] Bug 10120 : Tidy up the code so we can see what is going on Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended test plan used for testing: Note: Use a new item for each test as we determine fines by item number. If you have the same item twice on the same day on the same account with the same due date, fine calculation is going to fail. 1/ Create an overdue item, that should get fines 2/ Return the item from the patron account checkout tab 3/ Check the borrowers record to see if the fine has been added/updated Repeat, but for 2/ return the item from the check in page Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 from above 2/ Switch the preference to don't Repeat steps 1-2 3/ Check the fine hasn't been added/updated Again, check for returns from patron account and check in page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18144&action=edit [PASSED QA] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return On by default, To Test 1/ Create an overdue item, that should get fines 2/ Return the item 3/ Check the borrowers record to see if the fine has been added/updated Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 above 2/ Switch the preference to don't Repeat stes 1-2 3/ Check the fine hasn't been added/updated Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass, works as described. I would categorize this a bug fix for libraries that don't want the new changed behaviour that was introduced by recalculating fines on return. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18143|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18145&action=edit [PASSED QA] Bug 10120 : Tidy up the code so we can see what is going on Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended test plan used for testing: Note: Use a new item for each test as we determine fines by item number. If you have the same item twice on the same day on the same account with the same due date, fine calculation is going to fail. 1/ Create an overdue item, that should get fines 2/ Return the item from the patron account checkout tab 3/ Check the borrowers record to see if the fine has been added/updated Repeat, but for 2/ return the item from the check in page Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 from above 2/ Switch the preference to don't Repeat steps 1-2 3/ Check the fine hasn't been added/updated Again, check for returns from patron account and check in page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- String changes, so this will be held for 3.14/3.12.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|3.14 |master --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Back to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- For future reference, the IRC discussion in question starts at http://irc.koha-community.org/koha/2013-04-25#i_1239245 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- And a general comment: perhaps we should consider having loan records either store a copy of the circ policy that applies to the loan (e.g., issuelength, lengthunit, fine, finedays, etc.) or a reference to it (e.g,. by first giving issuingrules an opaque PK, then adding that as a FK to issues). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- And of course, Chris already suggested that. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton <gmcharlt@gmail.com> --- I have pushed the main patch to master, though with a bit of reluctance as I suspect the need for this syspref will go away if/when the underpinnings of fine accounting are improved. I have *not* pushed the follow-up whitespace patch; it might just be me, but I found that it made that section of code *less* readable, not more. Among other reasons, I really prefer that comments be indented at the same level as the block they apply to. I suggest that we just plan on running C4/Circulation.pm through perltidy at some point in the near future. Thanks, Chris! RMaint 3.12 please take note: I believed that this is considered a blocker by at least one library to upgrading. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10262 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44078&action=edit Bug 10120: (QA followup) avoid raising warnings on upgrade Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org