[Bug 33069] New: File download from list in OPAC gives error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Bug ID: 33069 Summary: File download from list in OPAC gives error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When trying to download the list contents in MARC in the OPAC, I get the following error: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The same records download ok from the cart. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 kevin.ayrault87@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.ayrault87@gmail.com --- Comment #2 from kevin.ayrault87@gmail.com --- I have the same error and after check the code, i see maybe the correction. In line 93, there is an extra "->" after "record" in my opinion. When I replace the line "my $record = $biblio->metadata->record->(" with "my $record = $biblio->metadata->record(", the download works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150619&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kévin AYRAULT from comment #2)
I have the same error and after check the code, i see maybe the correction. In line 93, there is an extra "->" after "record" in my opinion. When I replace the line "my $record = $biblio->metadata->record->(" with "my $record = $biblio->metadata->record(", the download works.
Thank you! This was the problem, with the change the error is gone :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150619|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 150631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150631&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Nasty error before the patch; nice, tasty MARC download after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Magnus :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150631|0 |1 is obsolete| | --- Comment #7 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 150807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150807&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Nasty error before the patch; nice, tasty MARC download after. Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150807|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150835&action=edit Bug 33069: Fix error in MARC download for OPAC lists There was a code typo causing an error when you tried to download a list in MARC format: Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93 To test: * In the OPAC: create a new list, public or private, with some records * Open the list * Try to download the list as MARC * Verify you get an error * Apply patch * Verify you now get the expected download file * Sign off :) Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Nasty error before the patch; nice, tasty MARC download after. Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org