[Bug 33296] New: Linker should search for authority records with an appropriate 008/14, 15, 16 value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Bug ID: 33296 Summary: Linker should search for authority records with an appropriate 008/14,15,16 value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Depends on: 33277 In an authority record, 008/14 = 'a' says it's appropriate for use as a main or added entry (1xx, 7xx), 008/15 = 'a' says it's appropriate for use as a subject entry, and 008/16 = 'a' says it's appropriate for use as a series entry (800-830, 440 since we still support it). In a world where we support multiple subject thesauri, we need a way to tell the difference between a name entry which intends to be used as a main entry and one which intends to only be used as a subject authority, and the way the subject-only one should say that is by having 008/14 = 'b' Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 [Bug 33277] Correctly handle linking subfields with no defined thesaurus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Using 008/16 would be a bit more trouble since AutoCreateAuthorities has never bothered setting it since we've never used it, but we already need to teach it new lessons for bug 31925 too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Bug 33296 depends on bug 33277, which changed state. Bug 33277 Summary: Correctly handle linking subfields with no defined thesaurus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- But we do have the virtually unused LinkerOptions to let people opt in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 38494 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38494 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #4 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 174957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174957&action=edit Bug 33296: Linker should search for authority records with an appropriate 008/14,15,16 value In an authority record, 008/14 = 'a' says it's appropriate for use as a main or added entry (1xx, 7xx), 008/15 = 'a' says it's appropriate for use as a subject entry, and 008/16 = 'a' says it's appropriate for use as a series entry. Test plan: ========== 1. Have a standard KTD environment. Have the patches from Bug 38494 applied. 2. Set AutoLinkBiblios system preference to 'Do', and ConsiderHeadingUse to 'Do'. 3. Open an existing bibliographic record and add a new field 650. In subfield $a enter 'Application software' (without quotes), and in $x 'Development.' (with final dot). 4. Save the record. In Normal view control that the entered subject heading entry has been linked with the existing authority record (note the magnifying glass icon). 5. Apply the patch ; restart all. 6. Repeat p. 3. Note that this time the newly entered subject heading entry has not been linked with the existing authority record. This is because the authority record has 008/15 = '|' while 'a' is required with ConsiderHeadingUse. 7. In Authorities, find the record for 'Application software--Development.' Modify it by changing 008/15 to 'a' (Heading use--subject added entry). 8. Return to the bibliographic record. Open it in the editor and save. The subject heading entry for 'Application software--Development.' should now be linked with the existing authority record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 174958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174958&action=edit Bug 33296: Unit tests Unit tests for Bug 33296. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38494 CC| |roman.dolny@jezuici.pl Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38494 [Bug 38494] Koha should consider authority heading use in cataloging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174957|0 |1 is obsolete| | Attachment #174958|0 |1 is obsolete| | --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 174959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174959&action=edit Bug 33296: Linker should search for authority records with an appropriate 008/14,15,16 value In an authority record, 008/14 = 'a' says it's appropriate for use as a main or added entry (1xx, 7xx), 008/15 = 'a' says it's appropriate for use as a subject entry, and 008/16 = 'a' says it's appropriate for use as a series entry. Test plan: ========== 1. Have a standard KTD environment. Have the patches from Bug 38494 applied. 2. Set AutoLinkBiblios system preference to 'Do', and ConsiderHeadingUse to 'Do'. 3. Open an existing bibliographic record and add a new field 650. In subfield $a enter 'Application software' (without quotes), and in $x 'Development.' (with final dot). 4. Save the record. In Normal view control that the entered subject heading entry has been linked with the existing authority record (note the magnifying glass icon). 5. Apply the patch ; restart all. 6. Repeat p. 3. Note that this time the newly entered subject heading entry has not been linked with the existing authority record. This is because the authority record has 008/15 = '|' while 'a' is required with ConsiderHeadingUse. 7. In Authorities, find the record for 'Application software--Development.' Modify it by changing 008/15 to 'a' (Heading use--subject added entry). 8. Return to the bibliographic record. Open it in the editor and save. The subject heading entry for 'Application software--Development.' should now be linked with the existing authority record. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 174960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174960&action=edit Bug 33296: Unit tests Unit tests for Bug 33296. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Dependency does not apply cleanly to main, marking this as BLOCKED until it is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174959|0 |1 is obsolete| | Attachment #174960|0 |1 is obsolete| | --- Comment #9 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177746&action=edit Bug 33296: Linker should search for authority records with an appropriate 008/14,15,16 value In an authority record, 008/14 = 'a' says it's appropriate for use as a main or added entry (1xx, 7xx), 008/15 = 'a' says it's appropriate for use as a subject entry, and 008/16 = 'a' says it's appropriate for use as a series entry. Test plan: ========== 1. Have a standard KTD environment. Have the patches from Bug 38494 applied. 2. Set AutoLinkBiblios system preference to 'Do', and ConsiderHeadingUse to 'Do'. 3. Open an existing bibliographic record and add a new field 650. In subfield $a enter 'Application software' (without quotes), and in $x 'Development.' (with final dot). 4. Save the record. In Normal view control that the entered subject heading entry has been linked with the existing authority record (note the magnifying glass icon). 5. Apply the patch ; restart all. 6. Repeat p. 3. Note that this time the newly entered subject heading entry has not been linked with the existing authority record. This is because the authority record has 008/15 = '|' while 'a' is required with ConsiderHeadingUse. 7. In Authorities, find the record for 'Application software--Development.' Modify it by changing 008/15 to 'a' (Heading use--subject added entry). 8. Return to the bibliographic record. Open it in the editor and save. The subject heading entry for 'Application software--Development.' should now be linked with the existing authority record. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 177747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177747&action=edit Bug 33296: Unit tests Unit tests for Bug 33296. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #11 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #8)
Dependency does not apply cleanly to main, marking this as BLOCKED until it is fixed.
Rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Depends on report that needs feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am seeing the code in a module now. Great. Should we adjust the other report for reusing this code ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #14 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Marcel de Rooy from comment #13)
I am seeing the code in a module now. Great. Should we adjust the other report for reusing this code ?
I'm not sure if it pays. biblio_tag is calculated differently in each case so there is only the main if in common, operating on 5 lists (@marclist, @and_or,...). I'm afraid that making a sub of this little if (where to put it to make it accessible to both?) would create more problems than solutions... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Your unit test is bitten by the new Test::NoWarnings stuff: # Failed test 'no warnings' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177747|0 |1 is obsolete| | --- Comment #16 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 179334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179334&action=edit Bug 33296: Unit tests Unit tests for Bug 33296. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177746|0 |1 is obsolete| | Attachment #179334|0 |1 is obsolete| | --- Comment #17 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 182763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182763&action=edit Bug 33296: Linker should search for authority records with an appropriate 008/14,15,16 value In an authority record, 008/14 = 'a' says it's appropriate for use as a main or added entry (1xx, 7xx), 008/15 = 'a' says it's appropriate for use as a subject entry, and 008/16 = 'a' says it's appropriate for use as a series entry. Test plan: ========== 1. Have a standard KTD environment. Have the patches from Bug 38494 applied. 2. Set AutoLinkBiblios system preference to 'Do', and ConsiderHeadingUse to 'Do'. 3. Open an existing bibliographic record and add a new field 650. In subfield $a enter 'Application software' (without quotes), and in $x 'Development.' (with final dot). 4. Save the record. In Normal view control that the entered subject heading entry has been linked with the existing authority record (note the magnifying glass icon). 5. Apply the patch ; restart all. 6. Repeat p. 3. Note that this time the newly entered subject heading entry has not been linked with the existing authority record. This is because the authority record has 008/15 = '|' while 'a' is required with ConsiderHeadingUse. 7. In Authorities, find the record for 'Application software--Development.' Modify it by changing 008/15 to 'a' (Heading use--subject added entry). 8. Return to the bibliographic record. Open it in the editor and save. The subject heading entry for 'Application software--Development.' should now be linked with the existing authority record. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #18 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 182764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182764&action=edit Bug 33296: Unit tests Unit tests for Bug 33296. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #19 from Janusz Kaczmarek <januszop@gmail.com> --- Rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182763|0 |1 is obsolete| | --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189074&action=edit Bug 33296: Linker should search for authority records with an appropriate 008/14,15,16 value In an authority record, 008/14 = 'a' says it's appropriate for use as a main or added entry (1xx, 7xx), 008/15 = 'a' says it's appropriate for use as a subject entry, and 008/16 = 'a' says it's appropriate for use as a series entry. Test plan: ========== 1. Have a standard KTD environment. Have the patches from Bug 38494 applied. 2. Set AutoLinkBiblios system preference to 'Do', and ConsiderHeadingUse to 'Do'. 3. Open an existing bibliographic record and add a new field 650. In subfield $a enter 'Application software' (without quotes), and in $x 'Development.' (with final dot). 4. Save the record. In Normal view control that the entered subject heading entry has been linked with the existing authority record (note the magnifying glass icon). 5. Apply the patch ; restart all. 6. Repeat p. 3. Note that this time the newly entered subject heading entry has not been linked with the existing authority record. This is because the authority record has 008/15 = '|' while 'a' is required with ConsiderHeadingUse. 7. In Authorities, find the record for 'Application software--Development.' Modify it by changing 008/15 to 'a' (Heading use--subject added entry). 8. Return to the bibliographic record. Open it in the editor and save. The subject heading entry for 'Application software--Development.' should now be linked with the existing authority record. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182764|0 |1 is obsolete| | --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189075&action=edit Bug 33296: Unit tests Unit tests for Bug 33296. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Bug 33296 depends on bug 38494, which changed state. Bug 38494 Summary: Koha should consider authority heading use in cataloging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38494 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33296 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #23 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org