https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #61 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, thanks for addressing the previous points. Upon looking again though, it appears there are a few more issues worth revisiting. Finding 1: editing a record now runs the duplicate check, on every install The follow-up "Check for duplicates when editing a bibliographic record" makes edits check for duplicates, including for frameworks with no matching rule, which fall back to the old title/author check. That's a behavior change for all sites and contradicts the release notes ("for use when creating new records"). If editing checks are wanted, could they be limited to frameworks with a matching rule, and the release notes updated? 1) Apply the patches, updatedatabase and restart_all (don't configure any matching rule) 2) Edit biblio 32 ('Alcestis'): http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=32 3) Change nothing, click 'Save' => Expected: the record is saved, as before the patches => Actual: 'Duplicate record suspected', pointing at biblio 33 ('Alcestis /') Finding 2: editing any framework other than Default fails The test plan only edits the Default framework, which is the one case that works. 1) Edit the 'Books, booklets, workbooks' framework: http://localhost:8081/cgi-bin/koha/admin/biblio_framework.pl?op=add_form&frameworkcode=BKS => Expected: 'Description' is an editable text field => Actual: it's shown as plain text 2) Click 'Submit' => Expected: the framework is saved => Actual: 'An error occurred when updating this framework. Perhaps it already exists.' Finding 3: with a matching rule set, the edit check misses duplicates depending on which record you edit 1) Because of Finding 2, set the ISBN rule ('020$a', id 1) on the BKS framework directly: sudo koha-mysql kohadev -e "INSERT INTO biblio_framework_marc_matcher (frameworkcode, marc_matcher_id, forbid_duplicate_creation) VALUES ('BKS', 1, 0);" 2) Edit biblio 252, change nothing, click 'Save': http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=252 => 'Duplicate record suspected', pointing at biblio 155 (same ISBN 0964479621) 3) Edit biblio 155, change nothing, click 'Save': http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=155 => Expected: the same warning, pointing at biblio 252 => Actual: it saves with no warning Finding 4: with 'Forbid creation of duplicate' on, a record that has a duplicate can't be edited 1) Continuing from Finding 3, turn on 'Forbid creation of duplicate' for BKS: sudo koha-mysql kohadev -e "UPDATE biblio_framework_marc_matcher SET forbid_duplicate_creation = 1 WHERE frameworkcode = 'BKS';" 2) Edit biblio 252, change nothing, click 'Save': http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=252 => Expected: the edit is saved (the option is about creating duplicates, not editing existing records) => Actual: 'Duplicate record found' with only an 'Edit existing items' button, so there's no way to save the edit -- You are receiving this mail because: You are watching all bug changes.