[Bug 43723] New: Superlibrarian is bit 0 of borrowers.flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43723 Bug ID: 43723 Summary: Superlibrarian is bit 0 of borrowers.flag Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- And only this one. The test in C4::Context::IsSuperLibrarian is using % 2, so flags = 3 will be considered superlibrarian. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43723 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |43425 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- This is not a security bug but depends on one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43723 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43723 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 207273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207273&action=edit Bug 43723: Use bitwise test in IsSuperLibrarian Superlibrarian is bit 0 of borrowers.flags. Test it with & 1 like the other flag checks (e.g. Koha::Patron->permissions) instead of % 2. No behaviour change expected, unless there are old entries in the borrowers table that predate the UI change that forbid the selection of superlibrarian and other top-level permissions? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org