[Bug 18542] New: Move and style "new field" link in item search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Bug ID: 18542 Summary: Move and style "new field" link in item search form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I propose to move the "New field" link in the item search form to the end of the last row in that section instead of below it, and to add a + icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63135&action=edit Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63135|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63137&action=edit Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. Behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63137|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65030&action=edit Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. Behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Fix indentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18542 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org