[Bug 35181] New: Can no longer edit sample records with advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Bug ID: 35181 Summary: Can no longer edit sample records with advanced cataloguing editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl I wonder if this is a side effect on the recent work on 'invalid metadata'. * Activate * Make sure you open any record with the advanced editor * Try to open: Perl best practices / Damian Conway. * You get stuck in loading * Javascript error shows "Invalid-metadata" on top of the MARC record, causing a syntax error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34014 Keywords| |regression CC| |nick@bywatersolutions.com --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- git bisect says 8dc2152e2f32b79abfe5f5531ddc225601498116 is the first bad commit commit 8dc2152e2f32b79abfe5f5531ddc225601498116 Author: Nick Clemens <nick@bywatersolutions.com> Date: Tue Oct 17 17:06:22 2023 +0000 Bug 34014: Add support for advanced cataloging editor And amusingly, you can edit at least one sample record, 369, the one with encoding errors. You just can't edit any record which does not have encoding errors. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 [Bug 34014] There is no way to fix records with broken MARCXML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158241&action=edit Bug 35181: Don't pass undef to header It seems passing an undef value causes the headers to be malformed. To test: 1 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 2 - Note 'Invalid-metadata' at top of page, as well as other headers 3 - Apply patch, restart all 4 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 5 - Page should now appear as xml 6 - Edit record 303, or any record with valid metadata in the advanced cataloging editor 7 - Confirm there is no error or alert 8 - Edit record 369 in the advanced cataloging editor 9 - Confirm there is an alert -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Severity|normal |major --- Comment #3 from David Nind <david@davidnind.com> --- After the patch, if I edit 303 (Pawn structure chess), I can: 1. Edit and save in the normal editor, even though the 003 tag is mandatory (I changed the title $245$a) 2. Get an error in the advanced editor: sort of pop up alert "Record structure invalid, cannot save", then "Missing mandatory tag: 003" at the top of the advanced editor. 3. If I edit "Programming perl" (262), the same thing occurs. Changed the priority of the bug to major. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Enica Davis <enica@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Nind from comment #3)
After the patch, if I edit 303 (Pawn structure chess), I can:
1. Edit and save in the normal editor, even though the 003 tag is mandatory (I changed the title $245$a)
2. Get an error in the advanced editor: sort of pop up alert "Record structure invalid, cannot save", then "Missing mandatory tag: 003" at the top of the advanced editor.
3. If I edit "Programming perl" (262), the same thing occurs.
Changed the priority of the bug to major.
That all makes sense - though the basic editor probably should enforce fields. If you add the 003 it saves normally? Or if it gives other errors, solve them too. Then all is good for SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- The book 303 is in the Audio Cassettes, CDs framework, which has 003 mandatory but not visible in the basic editor. That should probably be flagged in the framework test, but what the basic editor should do in that case is... unclear, but certainly not this bug. But the patch left a stray +# print $query->header( -type => 'text/xml', -charset => 'utf-8' ); in svc/bib, which is going to get you in trouble. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158241|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158276&action=edit Bug 35181: Don't pass undef to header It seems passing an undef value causes the headers to be malformed. To test: 1 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 2 - Note 'Invalid-metadata' at top of page, as well as other headers 3 - Apply patch, restart all 4 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 5 - Page should now appear as xml 6 - Edit record 303, or any record with valid metadata in the advanced cataloging editor 7 - Confirm there is no error or alert 8 - Edit record 369 in the advanced cataloging editor 9 - Confirm there is an alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158276|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 158284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158284&action=edit Bug 35181: Don't pass undef to header It seems passing an undef value causes the headers to be malformed. To test: 1 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 2 - Note 'Invalid-metadata' at top of page, as well as other headers 3 - Apply patch, restart all 4 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 5 - Page should now appear as xml 6 - Edit record 303, or any record with valid metadata in the advanced cataloging editor 7 - Confirm there is no error or alert 8 - Edit record 369 in the advanced cataloging editor 9 - Confirm there is an alert Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158284|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158376&action=edit Bug 35181: Don't pass undef to header It seems passing an undef value causes the headers to be malformed. To test: 1 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 2 - Note 'Invalid-metadata' at top of page, as well as other headers 3 - Apply patch, restart all 4 - Visit http://localhost:8081/cgi-bin/koha/svc/bib/303 5 - Page should now appear as xml 6 - Edit record 303, or any record with valid metadata in the advanced cataloging editor 7 - Confirm there is no error or alert 8 - Edit record 369 in the advanced cataloging editor 9 - Confirm there is an alert Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Bug 35181 depends on bug 34014, which changed state. Bug 34014 Summary: There is no way to fix records with broken MARCXML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iming@rosewoodfarm.com.au --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 35416 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #12 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 35443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org