[Bug 38128] New: Agreement/License user selection not limited to users with erm permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Bug ID: 38128 Summary: Agreement/License user selection not limited to users with erm permissions Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com The manual says that the user selection in ERM agreements and licences are limited to patrons with erm permissions. This is no longer true. I don't know if it is intentional, or a simple omission (possibly from Bug 35329). It made sense to limit the patron search this way, I think. To get there: 1. Enable ERMModule 2. Go to E-resource management > Agreement > New agreement 3. Click 'Add new user' 4. Click 'Select user' 5. Search for alford (for example) --> Jordan Alford is in the results, even if they don't have erm permissions 6. Go to Licences > New licence 7. Repeat steps 3-5 --> Jordan Alford is in the results, even if they don't have erm permissions I tried on a local 23.05 installation and Jordan Alford is not in the results, because they don't have erm permissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Bug 38128 depends on bug 35329, which changed state. Bug 35329 Summary: Move patron searches to a modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172556&action=edit Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission There was a silly mistake, we passed the TT var erm_users instead of the string "erm_users". It should also be passed to patron_search_modal to display the note. Test plan: Confirm that with this patch a patron search in the ERM module returns only patrons with the erm permission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172556|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172558&action=edit Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission There was a silly mistake, we passed the TT var erm_users instead of the string "erm_users". It should also be passed to patron_search_modal to display the note. Test plan: Confirm that with this patch a patron search in the ERM module returns only patrons with the erm permission. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @Caroline are you able to test this, as the original reporter of the bug? If you're able to add your SO, we can change mine to PQA to help this move in the queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172558|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173510&action=edit Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission There was a silly mistake, we passed the TT var erm_users instead of the string "erm_users". It should also be passed to patron_search_modal to display the note. Test plan: Confirm that with this patch a patron search in the ERM module returns only patrons with the erm permission. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Summary|Agreement/License user |Agreement/license user |selection not limited to |selection not limited to |users with erm permissions |users with ERM module | |permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174111&action=edit Bug 38128: Fix cypress test We were mocking the wrong route. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #6)
Created attachment 174111 [details] [review] Bug 38128: Fix cypress test
We were mocking the wrong route.
Thanks, picked follow-up for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35329 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org