[Bug 32312] New: Complete database column descriptions for serials module in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Bug ID: 32312 Summary: Complete database column descriptions for serials module in guided reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 29695 There are entries missing for the statistics table. How to test: * Add a new guided report * Select module serials * Verify that statistics is missing some descriptions, only showing the database value Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 [Bug 29695] Centralize columns' descriptions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Complete database column |Complete database column |descriptions for serials |descriptions for |module in guided reports |circulation module in | |guided reports --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are entries missing for the statistics table. How to test: * Add a new guided report * Select module circulation * Verify that statistics is missing some descriptions, only showing the database value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 [Bug 32292] Update and add database column descriptions used in guided reports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 144415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144415&action=edit Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds and clarifies release notes| |database column | |descriptions shown for the | |statistics table when | |creating a guided report | |for the circulation module. | |Previously, some columns | |didn't have a description | |or were ambiguous. Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 --- Comment #3 from David Nind <david@davidnind.com> --- For the statistics.other description: 1. C4/Stats.pm and C4/Circulation.pm indicate that the other field is used to record "sipmode". 2. The database schema comment is "used by SIP". I used the description 'SIP mode', although I'm not sure exactly what this means or records for a SIP transaction. I tried a checkout and a check in using SIP, but it didn't record anything additional in the column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144415|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 144532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144532&action=edit Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144532|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145875&action=edit Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |martin.renvoize@ptfs-europe | |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks David, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Bug 32312 depends on bug 32292, which changed state. Bug 32292 Summary: Update and add database column descriptions used in guided reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32292 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145875|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158037&action=edit Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Something wrong here, statistics was present already. 245 statistics => { 246 "datetime" => __("Statistics date and time"), 247 "branch" => __("Library"), 248 "value" => __("Value"), 249 "type" => __("Transaction type"), 250 "other" => __("SIP mode"), 251 "itemnumber" => __("Item number"), 252 "itemtype" => __("Koha item type"), 253 "location" => __("Shelving location"), 254 "borrowernumber" => __("Borrower number"), 255 "ccode" => __("Collection"), 256 "categorycode" => __("Patron category"), 257 }, 302 statistics => { 303 "borrowernumber" => __("Borrower number"), 304 "branch" => __("Library"), 305 "datetime" => __("Statistics date and time"), 306 "itemnumber" => __("Item number"), 307 "itemtype" => __("Itemtype"), 308 "other" => __(""), 309 "type" => __("Type"), 310 "value" => __("Value"), 311 }, In this second block "other" is getting __("") which leads to displaying the header of the po file when using a translated interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe a merge conflict? This has already been released, we should move to a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 [Bug 36796] Fix mistake in database column descriptions for statistics table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 36796 - Fix mistake in database column descriptions for statistics table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org