[Bug 16520] New: Per-virtualhost SetEnvs don't work with Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Bug ID: 16520 Summary: Per-virtualhost SetEnvs don't work with Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The various SetEnvs that can be used in Koha to configure memcached, change search limits, override sysprefs and add custom stylesheets don't work in Plack. It is likely impossible to fix this with the current HTTP proxy setup, so we need a workaround. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 51493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51493&action=edit Bug 16520: Allow per-VirtualHost environment variables with Plack This allows MEMCACHED_*, OVERRIDE_SYSPREF_* and others to work properly. Test plan: 1) Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; 2) Load the OPAC advanced search page (under Plack). The title should read "Koha online catalog" (or whatever your LibraryName syspref contains). 3) Add the following to your Apache configuration: RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\, Potato" 4) Restart Apache. 5) Refresh. The title should now read "Potato, Potato online catalog". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 51494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51494&action=edit Bug 16520: Initialize the sysprefs Koha::Cache on demand This is needed so that the cache singleton doesn't get created before the MEMCACHED_* environment variables are set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #3 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 51495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51495&action=edit Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files This was not added to the old etc/koha-httpd.conf because that file has no infrastructure for Plack anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 51496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51496&action=edit Bug 16520: Fix the Apache Plack config to load the main page through Plack Previously, the ProxyPass would not pass the OPAC/staff homepage to Plack. This fixes this problem (which is necessary for the other changes on this bug to show on the main page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51493|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51576&action=edit Bug 16520: Allow per-VirtualHost environment variables with Plack This allows MEMCACHED_*, OVERRIDE_SYSPREF_* and others to work properly. Test plan: 1) Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; 2) Load the OPAC advanced search page (under Plack). The title should read "Koha online catalog" (or whatever your LibraryName syspref contains). 3) Add the following to your Apache configuration: RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\, Potato" 4) Restart Apache. 5) Refresh. The title should now read "Potato, Potato online catalog". Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51494|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51577&action=edit Bug 16520: Initialize the sysprefs Koha::Cache on demand This is needed so that the cache singleton doesn't get created before the MEMCACHED_* environment variables are set. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51495|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51578&action=edit Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files This was not added to the old etc/koha-httpd.conf because that file has no infrastructure for Plack anyway. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51496|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51579&action=edit Bug 16520: Fix the Apache Plack config to load the main page through Plack Previously, the ProxyPass would not pass the OPAC/staff homepage to Plack. This fixes this problem (which is necessary for the other changes on this bug to show on the main page). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51580&action=edit Bug 16520: (followup) use __MEMCACHED_NAMESPACE__ where appropriate Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I tested this patches and I verified they correctly make the ENV variables reach the plack backend. Thus, the OVERRIVE_SYS* work again, and the memcached variables are correctly set. To verify the latter, I wrote a small patch that would go to another bug to display memcached configuration/status in about.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Jesse, It does not work for me, could you please have a look at the test plan and make sure all tests are listed? For instance, it seems that debian/templates/apache-shared-intranet-plack.conf and debian/templates/apache-shared-opac-plack.conf need to be copied (I did but still does not work). Code review: Should not we test if the headers mod is enabled in debian/templates/apache-site.conf.in? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #11)
Jesse, It does not work for me, could you please have a look at the test plan and make sure all tests are listed?
s/tests/steps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan, what i did for testing was applying the changes manually to my kohadevbox instance. I agree the headers module should be correctly checked. The patched config files worked for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #13)
Jonathan, what i did for testing was applying the changes manually to my kohadevbox instance. I agree the headers module should be correctly checked. The patched config files worked for me.
Yep I have double checked everything and it now works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have to admit I am a bit lost with all the apache config files, but should not we move the RequestHeader add X-Koha-SetEnv lines to apache-shared-[intranet|opac]-plack.conf files? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- In C4::Context->preference, the lc $var has been moved after the OVERRIDE_SYSPREF_* check, I don't think it's expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 108 # We also add the MEMCACHED_ settings to the actual environment, to make sure any early 109 # initialization of Koha::Cache correctly sets up a memcached connection. 110 foreach my $special_var ( qw( MEMCACHED_SERVERS MEMCACHED_NAMESPACE ) ) { 111 $ENV{$special_var} = $setenvs{$special_var} if defined $setenvs{$special_var}; 112 } Jesse, could you explain in which cases this is useful? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #18 from Jesse Weaver <jweaver@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #15)
I have to admit I am a bit lost with all the apache config files, but should not we move the RequestHeader add X-Koha-SetEnv lines to apache-shared-[intranet|opac]-plack.conf files?
I'm inclined to agree; at first I was thinking to have an example of the new syntax in the configuration files, but given that this should be wrapped in an <IfModule>, it should be moved there. (In reply to Jonathan Druart from comment #16)
In C4::Context->preference, the lc $var has been moved after the OVERRIDE_SYSPREF_* check, I don't think it's expected.
This is in tune with the documentation and how this feature has been historically used; see http://manual.koha-community.org/3.22/en/administration.html#globalsysprefs . (In reply to Jonathan Druart from comment #17)
108 # We also add the MEMCACHED_ settings to the actual environment, to make sure any early 109 # initialization of Koha::Cache correctly sets up a memcached connection. 110 foreach my $special_var ( qw( MEMCACHED_SERVERS MEMCACHED_NAMESPACE ) ) { 111 $ENV{$special_var} = $setenvs{$special_var} if defined $setenvs{$special_var}; 112 }
Jesse, could you explain in which cases this is useful?
C4::Auth, in my testing, loads up some system preferences early on that cause Koha::Cache to be initialized before the Plack environment is copied to %ENV (presumably by the Plack CGI wrapper?). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #19 from Jesse Weaver <jweaver@bywatersolutions.com> --- I was poking at this, and one issue with moving those sysprefs is that the apache-*-plack.conf files are not .in files, so __MEMCACHED_NAMESPACE__ is not replaced in them. I could rejigger that, but any strenuous objections to leaving the RequestHeader lines where I currently have them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51576|0 |1 is obsolete| | Attachment #51577|0 |1 is obsolete| | Attachment #51578|0 |1 is obsolete| | Attachment #51579|0 |1 is obsolete| | Attachment #51580|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56309&action=edit Bug 16520: Allow per-VirtualHost environment variables with Plack This allows OVERRIDE_SYSPREF_* and others to work properly. Test plan: 1) Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; 2) Load the OPAC advanced search page (under Plack). The title should read "Koha online catalog" (or whatever your LibraryName syspref contains). 3) Add the following to your Apache configuration: RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\, Potato" 4) Restart Apache. 5) Refresh. The title should now read "Potato, Potato online catalog". Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56310&action=edit Bug 16520: Initialize the sysprefs Koha::Caches on demand Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56311&action=edit Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files This was not added to the old etc/koha-httpd.conf because that file has no infrastructure for Plack anyway. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56312&action=edit Bug 16520 (Follow up) Rebase fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56309|0 |1 is obsolete| | Attachment #56310|0 |1 is obsolete| | Attachment #56311|0 |1 is obsolete| | Attachment #56312|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 56397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56397&action=edit Bug 16520: Allow per-VirtualHost environment variables with Plack This allows OVERRIDE_SYSPREF_* and others to work properly. Test plan: 1) Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; 2) Load the OPAC advanced search page (under Plack). The title should read "Koha online catalog" (or whatever your LibraryName syspref contains). 3) Add the following to your Apache configuration: RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\, Potato" 4) Restart Apache. 5) Refresh. The title should now read "Potato, Potato online catalog". Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #25 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56397|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 56410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56410&action=edit Bug 16520: Allow per-VirtualHost environment variables with Plack This allows OVERRIDE_SYSPREF_* and others to work properly. Test plan: 1) Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; 2) Load the OPAC advanced search page (under Plack). The title should read "Koha online catalog" (or whatever your LibraryName syspref contains). 3) Add the following to your Apache configuration: RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\, Potato" 4) Restart Apache. 5) Refresh. The title should now read "Potato, Potato online catalog". Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 56411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56411&action=edit Bug 16520: Initialize the sysprefs Koha::Caches on demand Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 56412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56412&action=edit Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files This was not added to the old etc/koha-httpd.conf because that file has no infrastructure for Plack anyway. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 56413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56413&action=edit Bug 16520 (Follow up) Rebase fixes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would have liked to take a look at this one before pushing it. Especially because it modifies the syspref cache code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #30)
I would have liked to take a look at this one before pushing it. Especially because it modifies the syspref cache code.
Would have been good to launch the tests: prove t/db_dependent/Context.t t/db_dependent/Context.t .. 1/? Can't call method "set_in_cache" on an undefined value at /home/vagrant/kohaclone/C4/Context.pm line 533. Caused by commit 174769e382dfd5205595a5b9ae7b58c8ebf5d850 Bug 16520 (Follow up) Rebase fixes Please fix it ASAP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57372&action=edit Bug 16520 - (Follow up) Restore retrieval of syspref_cache -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57372|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57383&action=edit Bug 16520 - (Follow up) Restore retrieval of syspref_cache Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Followup pushed to master thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #35 from Magnus Enger <magnus@libriotech.no> --- Reading this bug, I thought I had to do thos step in order to be able to set per-OPAC variables in my Apache config: Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; But there is no such thing as Koha::Middleware::Plack, so adding the line made this error show up in the Plack error log: Error while loading /etc/koha/sites/x/plack.psgi: Can't locate Koha/Middleware/Plack.pm in @INC (you may need to install the Koha::Middleware::Plack module) (@INC contains: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /usr/share/perl5/Plack/Util.pm line 23, <DATA> line 309. Turns out Koha::Middleware::Plack is not needed, all you need is already in the out-of-the-box .psgi file. Not sure why. Maybe Koha::Middleware::Plack was just a typo for Koha::Middleware::SetEnv all along? http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=1e6df24d6cbf44c8... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31042 [Bug 31042] OVERRIDE_SYSPREF does not work for REST API -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org