[Bug 14717] New: Adding a new patron can end up with 0000-00-00 as the debarred date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Bug ID: 14717 Summary: Adding a new patron can end up with 0000-00-00 as the debarred date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 12633 introduced a bug, that where debarred is blank, the column is being filled with 0000-00-00 You can test this by importing a patron using the import tool, the patron must have no debarred date set. Then check in the DB and you will notice it has an invalid date 0000-00-00 This in turn makes Koha error in circulation as we try to truncate and invalid date object. Adding $data{'debarred'} = undef if( not $data{'debarred'} ); to the AddMembers subroutine should fix this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 41871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41871&action=edit Bug 14717: Invalid dates in debarred column To test 1/ Import a patron using the patron import tool, make sure they have no debarred column in the file 2/ Check the database, notice the debarred column is 0000-00-00 3/ For bonus points, checkout an item to that borrower, then check it in notice Koha errors 4/ Apply patch 5/ Import a new patron 6/ Notice column is now NULL and that checkins work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Ohh look an easily testable patch that fixes a major bug .. just waiting for Global bug squash day :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Eugene Espinoza <eugenegf@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |eugenegf@yahoo.com --- Comment #3 from Eugene Espinoza <eugenegf@yahoo.com> --- I tested this during GBSD together with Kyle. And the patch works! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41871|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42331&action=edit [SIGNED-OFF] Bug 14717: Invalid dates in debarred column To test 1/ Import a patron using the patron import tool, make sure they have no debarred column in the file 2/ Check the database, notice the debarred column is 0000-00-00 3/ For bonus points, checkout an item to that borrower, then check it in notice Koha errors 4/ Apply patch 5/ Import a new patron 6/ Notice column is now NULL and that checkins work Signed-off-by: Eugene Espinoza <eugenegf@yahoo.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42331|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42342&action=edit Bug 14717: Invalid dates in debarred column To test 1/ Import a patron using the patron import tool, make sure they have no debarred column in the file 2/ Check the database, notice the debarred column is 0000-00-00 3/ For bonus points, checkout an item to that borrower, then check it in notice Koha errors 4/ Apply patch 5/ Import a new patron 6/ Notice column is now NULL and that checkins work Signed-off-by: Eugene Espinoza <eugenegf@yahoo.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42343&action=edit Bug 14717: Prevent 0000-00-00 on updating a patron Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42344&action=edit Bug 14171: Update borrowers date fields Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chris@bigballofwax.co.nz |ity.org | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think we should go further here. Can I get a QA on the new patches? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding a new patron can end |Prevent 0000-00-00 dates in |up with 0000-00-00 as the |patron data |debarred date | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42356&action=edit [PASSED QA] Bug 14717: Invalid dates in debarred column To test 1/ Import a patron using the patron import tool, make sure they have no debarred column in the file 2/ Check the database, notice the debarred column is 0000-00-00 3/ For bonus points, checkout an item to that borrower, then check it in notice Koha errors 4/ Apply patch 5/ Import a new patron 6/ Notice column is now NULL and that checkins work Signed-off-by: Eugene Espinoza <eugenegf@yahoo.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42357&action=edit [PASSED QA] Bug 14717: Prevent 0000-00-00 on updating a patron Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42358&action=edit [PASSED QA] Bug 14171: Update borrowers date fields Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> http://bugs.koha-community.org/show_bug.cgi?id=14717 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #42342|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good catch Chris! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org