[Bug 30403] New: Update notforloan status also on check put
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Bug ID: 30403 Summary: Update notforloan status also on check put Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We currently have syspref UpdateNotForLoanOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be useful if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be changed to 0, informing staff that the item is back on circulation and not longer present in the exhibition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 132534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132534&action=edit Bug 30403: Add syspref UpdateNotForLoanOnCheckout We currently have syspref UpdateNotForLoanOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update notforloan status |Update notforloan status |also on check put |also on check out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132534|0 |1 is obsolete| | --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 132535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132535&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy ---- Previous patch had typos in description (missing Status from both sysprefs). This is just a readd to fix them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132535|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 132536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132536&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Rachael <rachael.laritz@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachael.laritz@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Rachael <rachael.laritz@inlibro.com> --- patch does not apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132536|0 |1 is obsolete| | --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139675&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 catherine.dupuy-lenen@univ-rennes1.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.dupuy-lenen@univ- | |rennes1.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Missing the sign-off (line?) here, but also don't see a comment from testing. Please verify! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi, they tested it and only changed the status. I sent a message with how to signoff the patches via the sandboxes. So it should be in order shortly and switched to signed-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 catherine.dupuy-lenen@univ-rennes1.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from catherine.dupuy-lenen@univ-rennes1.fr --- I tested this patch once (Koha 21.05 or 21.11, I don't remember) and it worked, but when I retest (koha 22.06) I get an error when I apply the patch : "Applying: Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M t/db_dependent/Circulation/issue.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation/issue.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation/issue.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
I tested this patch once (Koha 21.05 or 21.11, I don't remember)
How did you test it on 21.05 or 21.11? The sandboxes can't work if trying to get an older version of Koha. Anyway, setting this to "patch does not apply" since that's the current blocker. Don't hesitate to do this if when applying a patch in a sandbox you get "CONFLICT (content): Merge conflict" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139675|0 |1 is obsolete| | --- Comment #10 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 142915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142915&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142915|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 143883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143883&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Catrina <catrina@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143883|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144681&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144681|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144682&action=edit Bug 30403: Add syspref UpdateNotForLoanStatusOnCheckout We currently have syspref UpdateNotForLoanStatusOnCheckin which updates notforloan status when item is checked in. We should also have same kind of syspref for check outs. This would be usefull if for example library has item in exhibition with status "In exhibition, available for loan". When patron check outs the item notforloan status can be reseted back to 0, informing staff that the item is back on circulation. This patch adds new syspref Add syspref UpdateNotForLoanStatusOnCheckout. To test: 1. Set items notforloan status as e.g -1. 2. Check out item for a patron. => Note that items status doesn't change. 3. Apply patch and update database if needed. 4. Add "-1: 0" to syspref UpdateNotForLoanStatusOnCheckout. 5. Check item in and out again for a patron. => Note that items status is changed as 0. Also prove t/db_dependent/Circulation/issue.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144683&action=edit Bug 30403: (QA follow-up) Fix warning in unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144684&action=edit Bug 30403: (QA follow-up) Fix up atomic update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 [Bug 33431] Make code use C4::Context->yaml_preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 149234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149234&action=edit Bug 30403: (QA follow-up) Add new YAML syspref to about.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara@ptfs-europe.com --- Comment #18 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/687 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34720 [Bug 34720] UpdateNotForLoanStatusOnCheckin should be named UpdateNotForLoanStatusOnCheckout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rachael.laritz@inlibro.com |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35292 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org