[Bug 23202] New: Problems when adding multiple items to an order in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Bug ID: 23202 Summary: Problems when adding multiple items to an order in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- We have had reports of problems when adding multiple items to an order The problem is like: 1 - Add to a basket with AcqCreateItems set to 'ordering' 2 - Scroll to bottom of item section and click 'Add multiple items' 3 - Add 40+ items 4 - Screen freezes on 'Processing multiple items' This cannot be recreated consistently, but we have had recurring reports from an institution that orders many copies of items often -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nothing in the logs? What is their barcode settings? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #2 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- We got this problem too. Seems that the dateaccessioned.pl plugin in items dateaccessioned field is creating this. It is a javascript problem the flatpickr structure prevents items to be cloned in additem.js file. I can take this bug and fix it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Johanna, thx for this! Could it be related to bug 30975 somehow? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #4 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #3)
Hi Johanna, thx for this! Could it be related to bug 30975 somehow?
I think that is a different problem, more of Jquery behavior. In this bug the browser console gives this error: Uncaught TypeError: $(...).parent(...).attr(...) is undefined So with flatpickr datefield it doesn't find correct attribute to continue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can replicate the issue, when the 'date acquired' is filled in. This gives the error every time on adding multiple items: Uncaught TypeError: $(...).parent(...).attr(...) is undefined Johanna, are you still working on a fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #6 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #5)
I can replicate the issue, when the 'date acquired' is filled in. This gives the error every time on adding multiple items:
Uncaught TypeError: $(...).parent(...).attr(...) is undefined
Johanna, are you still working on a fix?
I'm on to it. Just came from summer vacation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Johanna Räisä from comment #6)
(In reply to Katrin Fischer from comment #5)
I can replicate the issue, when the 'date acquired' is filled in. This gives the error every time on adding multiple items:
Uncaught TypeError: $(...).parent(...).attr(...) is undefined
Johanna, are you still working on a fix?
I'm on to it. Just came from summer vacation.
Thx! Will try to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #8 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 138120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138120&action=edit Bug 23202: Problems when adding multiple items to an order in acquisitions This patch fixes adding multiple items on order acquisitions 1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field. 2) Create basket to a vendor and add order from a new empty record. 3) Add date acquired value from calendar. 4) Add multiple items and see that the view freezes. 5) Apply the patch 6) Reload the page and repeat the steps 3 and 4. 7) See that the items are added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #9 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Ahh, forgot to change the status. Here you go! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138120|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138395&action=edit Bug 23202: Problems when adding multiple items to an order in acquisitions This patch fixes adding multiple items on order acquisitions 1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field. 2) Create basket to a vendor and add order from a new empty record. 3) Add date acquired value from calendar. 4) Add multiple items and see that the view freezes. 5) Apply the patch 6) Reload the page and repeat the steps 3 and 4. 7) See that the items are added. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tried add multi when ordering, receiving and cataloguing, all good. Johanna, please have a look at https://wiki.koha-community.org/wiki/Commit_messages#Examples Most of the time the bug report title and the commit title must be different (what the bug is vs what the patch does). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138395|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139244&action=edit Bug 23202: Fix screen freeze when ordereing several items This patch fixes adding multiple items on order acquisitions The error is: Uncaught TypeError: $(...).parent(...).attr(...) is undefined Test plan: 1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field. 2) Create basket to a vendor and add order from a new empty record. 3) Add date acquired value from calendar. 4) Add multiple items and see that the view freezes. 5) Apply the patch 6) Reload the page and repeat the steps 3 and 4. 7) See that the items are added. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: adjust commit title Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch does not make the code more robust but it fixes the problem without introducing new regressions (hopefully!). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 32175 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202 Bug 23202 depends on bug 29239, which changed state. Bug 29239 Summary: [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org