https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 [Bug 22435] account_offset types should be codes not descriptions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118339&action=edit Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |sally.healey@cheshireshared | |services.gov.uk, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118339|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118426&action=edit Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118428&action=edit Bug 27967: Add min attribute to borraccount modals This patch adds a min attribute to the form fields of the borrower account page modals to prevent negative values being entered inappropriately. Test plan 1/ Trigger the refund modal from the borrower account page. 2/ Attempt to enter a negative value for the amount to refund and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 3/ Trigger the discount modal from the borrower account page. 4/ Attempt to enter a negative value for the amount to discount and note with the patch applied you face a validation error (without the patch, upon submission of a negative value you will be faced with a server side error) 5/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22435 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 [Bug 22435] account_offset types should be codes not descriptions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.