https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |lari.taskula@jns.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 65195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65195&action=edit Bug 18976: Fix t/db_dependent/Auth.t cleanup Test t/db_dependent/Auth.t seems to have an ineffective test data cleanup. Data generated by TestBuilder is left in borrowers, branches, categories, sms_providers and sessions tables after the test. To replicate: 1. Check the row count of borrowers, branches and categories tables 2. prove t/db_dependent/Auth.t 3. Repeat step 1 4. Observe borrowers the following tables have increased in row count: - borrowers - branches - categories - sessions - sms_providers To test: 1. Before applying the patch, go through steps at "To replicate" plan 2. Apply patch 3. Go through steps at "To replicate" plan 4. Observe step 4 no longer applies and those tables have the same number of rows as before executing the test. This issue has been happening in REST tests as well, and this solution is directly copy-pasted from t/db_dependent/api/v1/cities.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17427 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by CGI::Session, see bug 17427. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65195|0 |1 is obsolete| | Attachment #65197|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65284&action=edit Bug 18976: Fix t/db_dependent/Auth.t cleanup Test t/db_dependent/Auth.t seems to have an ineffective test data cleanup. Data generated by TestBuilder is left in borrowers, branches, categories, sms_providers and sessions tables after the test. To replicate: 1. Check the row count of borrowers, branches and categories tables 2. prove t/db_dependent/Auth.t 3. Repeat step 1 4. Observe borrowers the following tables have increased in row count: - borrowers - branches - categories - sessions - sms_providers To test: 1. Before applying the patch, go through steps at "To replicate" plan 2. Apply patch 3. Go through steps at "To replicate" plan 4. Observe step 4 no longer applies and those tables have the same number of rows as before executing the test. This issue has been happening in REST tests as well, and this solution is directly copy-pasted from t/db_dependent/api/v1/cities.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping QA, it will fixes selenium tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.03. In order to correct selenium test failures. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65390&action=edit Bug 18976: [16.11] Add missing use statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.16 release -- You are receiving this mail because: You are watching all bug changes.