[Bug 38013] New: Some return messages in returns.tt lack specific classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Bug ID: 38013 Summary: Some return messages in returns.tt lack specific classes Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Most of the messages that Koha might display on the checkin page have distinct classes. We do not apply a specific class when a checkout had an issue note: https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6... Or when the patron has fines: https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6... We should do so in both cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrewfh@dubcolib.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 172116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172116&action=edit Bug 38013: Add classes to messages in returns.tt To test: 1 - enable FineNotifyAtCheckin 2 - enable AllowCheckoutNotes 3 - check out an item to a patron with fines on their account 4 - check out an item and place a checkout note on it 5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning 6 - apply patch, restart_all 7 - repeat steps 3 and 4 8 - check items in, confirm messages now include issue-note and patron-fines classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172116|0 |1 is obsolete| | --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 172136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172136&action=edit Bug 38013: Add classes to messages in returns.tt To test: 1 - enable FineNotifyAtCheckin 2 - enable AllowCheckoutNotes 3 - check out an item to a patron with fines on their account 4 - check out an item and place a checkout note on it 5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning 6 - apply patch, restart_all 7 - repeat steps 3 and 4 8 - check items in, confirm messages now include issue-note and patron-fines classes Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- testing notes: To easily create a checkout with fines Define fine rules Specify a backdated due date at checkout Run fines.pl cronjob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172136|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173526&action=edit Bug 38013: Add classes to messages in returns.tt To test: 1 - enable FineNotifyAtCheckin 2 - enable AllowCheckoutNotes 3 - check out an item to a patron with fines on their account 4 - check out an item and place a checkout note on it 5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning 6 - apply patch, restart_all 7 - repeat steps 3 and 4 8 - check items in, confirm messages now include issue-note and patron-fines classes Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some return messages in |Some checkin messages on |returns.tt lack specific |checkins page lack specific |classes |classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some checkin messages on |Some checkin messages on |checkins page lack specific |checkins page lack specific |classes |CSS classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38013 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Merge conflicts with 24.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org